Bug 296070 - Move ThumbnailBar from BoxSwitch to CoverSwitch
Summary: Move ThumbnailBar from BoxSwitch to CoverSwitch
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-tabbox (show other bugs)
Version: git master
Platform: unspecified Linux
: NOR wishlist
Target Milestone: 4.11
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks: 296071
  Show dependency treegraph
 
Reported: 2012-03-15 13:51 UTC by Martin Flöser
Modified: 2013-04-24 10:03 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 4.11.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Flöser 2012-03-15 13:51:48 UTC
Currently CoverSwitch uses the effect proxy to render the thumbnail bar. As BoxSwitch is no longer used for window switching the functionality should be moved directly into coverswitch.
Comment 1 Thomas Lübking 2012-03-15 14:12:45 UTC
Or just drop it?
What is the additional switcher supposed to fix/improve?

If you've too many windows, the box switch with many tiny windows won't help -> present windows.
Otherwise i -personally- find it nothing but distracting to have two window lists at once.
Comment 2 Martin Flöser 2012-03-15 15:43:17 UTC
> Or just drop it?
Also a valid option. Will think about it :-)
Comment 3 Martin Flöser 2013-04-24 10:03:32 UTC
Git commit 096de09a0e308faa944c45bb69723e2907da1b19 by Martin Gräßlin.
Committed on 01/04/2012 at 09:04.
Pushed by graesslin into branch 'master'.

Remove thumbnail bar from CoverSwitch Effect

The usage has always been questionable as the thumbnails are
too small to properly recognize something.

Now BoxSwitch Effect has reach its end of life which would have
required to keep most of the code just for this thumbnail bar.

If required it would be better to integrate the normal QML based
TabBox to be rendered together with an effect.
FIXED-IN: 4.11.0

M  +0    -18   kwin/effects/coverswitch/coverswitch.cpp
M  +0    -12   kwin/effects/coverswitch/coverswitch.h
M  +0    -9    kwin/effects/coverswitch/coverswitch.kcfg
M  +0    -12   kwin/effects/coverswitch/coverswitch_config.cpp
M  +0    -3    kwin/effects/coverswitch/coverswitch_config.h
M  +5    -97   kwin/effects/coverswitch/coverswitch_config.ui

http://commits.kde.org/kde-workspace/096de09a0e308faa944c45bb69723e2907da1b19