Bug 295843 - Do not hardcode group chat theme
Summary: Do not hardcode group chat theme
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Frameworks and Libraries
Component: text-ui (show other bugs)
Version: git-latest
Platform: unspecified Linux
: NOR wishlist
Target Milestone: 0.6.0
Assignee: Telepathy Bugs
URL: What proprietary software do you use?...
Keywords:
: 282518 316574 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-03-12 14:51 UTC by Daniele E. Domenichelli
Modified: 2013-03-15 23:30 UTC (History)
4 users (show)

See Also:
Latest Commit: http://commits.kde.org/telepathy-text-ui/d641de956eafa0208749d785c0c2fc4f374ecaef
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Daniele E. Domenichelli 2012-03-12 14:51:58 UTC 
We can just duplicate the single user chat configuration and let the user choose a theme for group chats.
Comment 1 Fabian Henze 2012-10-30 10:29:08 UTC 
Quite annoying bug for me. Wouldn't it be possible to use the normal chat theme for group chats till the gui is ready? Or a hidden option in the config file?
Comment 2 Martin Klapetek 2012-10-30 10:39:10 UTC 
The normal one (renkoo) just does not work with group chats. As in - it's unusable.
Comment 3 Daniele E. Domenichelli 2013-03-12 08:22:41 UTC 
Can we make this blocking for 0.6.0? There is already a patch on reviewboard (that needs to be updated) https://git.reviewboard.kde.org/r/108571/ And I think this is quite an important missing feature
Comment 4 Daniele E. Domenichelli 2013-03-12 08:22:54 UTC 
*** Bug 316574 has been marked as a duplicate of this bug. ***
Comment 5 Martin Klapetek 2013-03-12 11:11:00 UTC 
*** Bug 282518 has been marked as a duplicate of this bug. ***
Comment 6 David Edmundson 2013-03-15 23:30:59 UTC 
Git commit d641de956eafa0208749d785c0c2fc4f374ecaef by David Edmundson.
Committed on 15/03/2013 at 02:40.
Pushed by davidedmundson into branch 'master'.

Allow seperate config for group chats

Split AppearanceConfig into tabs
Make showPresenceMode a boolean now that we have separate configgroups for single and group modes

REVIEW: 108571

M  +3    -2    app/chat-window.cpp
M  +1    -1    config/CMakeLists.txt
C  +138  -131  config/appearance-config-tab.cpp [from: config/appearance-config.cpp - 065% similarity]
C  +28   -21   config/appearance-config-tab.h [from: config/appearance-config.h - 065% similarity]
M  +22   -265  config/appearance-config.cpp
M  +4    -25   config/appearance-config.h
M  +4    -29   config/appearance-config.ui
M  +11   -11   lib/adium-theme-view.cpp
M  +3    -9    lib/adium-theme-view.h
M  +1    -2    lib/chat-widget.cpp

http://commits.kde.org/telepathy-text-ui/d641de956eafa0208749d785c0c2fc4f374ecaef