Bug 295357 - When trying to store a mail ("Save as") with a file name that contains invalid characters, no error message is given and the mail is not stored.
Summary: When trying to store a mail ("Save as") with a file name that contains invali...
Status: RESOLVED WORKSFORME
Alias: None
Product: kmail2
Classification: Applications
Component: commands and actions (show other bugs)
Version: 4.8
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2012-03-05 10:33 UTC by itsef-admin
Modified: 2018-10-27 04:01 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description itsef-admin 2012-03-05 10:33:33 UTC
User-Agent:       Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:10.0.2) Gecko/20100101 Firefox/10.0.2
Build Identifier: 

Background: When storing e-mail, the file name can contain characters that are not allowed on the filesystem where the file is supposed to be stored. KMail2 fails to catch this.

Reproducible: Always

Steps to Reproduce:
1. Select an e-mail in the message list
2. File -> Save as
3. Enter a file name with an illegal character (examples: "lists/scheudules.mbox" on ext4 or "Maybe interesting?.mbox" on FAT32)
4. Click on "Save"
Actual Results:  
No error message is given.
The mail is *not* saved.

Expected Results:  
KMail2 should give an error message. Ideally, this message should state that the file name contains illegal characters. Failing that, the file system errors of the OS should be passed through (I think that's what KMail1 did - KMail1 does throw an error in theses cases).
In any case, KMail2 should not just silently fail, as this is very confusing for users.
Comment 1 Laurent Montel 2012-03-05 18:45:03 UTC
Works fine here.
We have a messagebox when we can't save message (perhaps a fix after 4.8.0)

Ok message was bad I fixed it in 4.9 (add new i18n)
Comment 2 itsef-admin 2012-03-07 08:12:05 UTC
I'm not sure I understand your last comment. I have just re-tried with 4.8.1 (Kubuntu-ppa) and there is no error message when I try to save a file with an invalid name. It still fails silently.
Comment 3 Laurent Montel 2012-03-07 09:16:44 UTC
I have a messagebox to signal that it's bad.
So don't know
Comment 4 itsef-admin 2012-03-07 11:02:57 UTC
Strange. It is really consistent over here - several users have seen it and in my own tests, I've tried to store on ext4 (/tmp), NFS4 ($HOME) and FAT32 (USB stick). No error messages in any of those cases. If you are aware of anything outside of Kontact that could prevent error messages from showing I'd be grateful for suggestions.
Comment 5 itsef-admin 2012-03-08 12:54:24 UTC
I just ran strace against Kontact while trying to store "pgp?testmail.mbox" on a FAT32/VFAT-formatted USB-stick. In the strace, I can see plenty of lines like
lstat64("/media/36F3-0BF4/pgp?testmail.mbox", 0xbffdfabc) = -1 ENOENT (No such file or directory)
[...]
lstat64("/home/USER/.kde/share/apps/RecentDocuments/pgp?testmail.mbox.desktop", 0xbffdf9ec) = -1 ENOENT (No such file or directory)
[...]
unlink("/media/36F3-0BF4/pgp?testmail.mbox") = -1 ENOENT (No such file or directory)
stat64("/media/36F3-0BF4/pgp?testmail.mbox", 0xbffe2008) = -1 ENOENT (No such file or directory)
open("/media/36F3-0BF4/pgp?testmail.mbox", O_RDWR|O_CREAT|O_LARGEFILE|O_CLOEXEC, 0666) = -1 EINVAL (Invalid argument)

And thereafter no more mentioning of that file name. It looks as if the OS is indeed giving back the error, but KMail2 just does not do anything with it. If there is anything else you would like to test me specifically, please let me know.
Comment 6 Laurent Montel 2012-07-12 07:05:34 UTC
I retested it and work fine.
Ok for you in 4.9 ?
Comment 7 Laurent Montel 2012-07-24 11:36:12 UTC
wait for infos
Comment 8 itsef-admin 2012-09-06 15:35:30 UTC
I'm now on Kubuntu 12.04/Kontact 4.8.4. This bug is still present - no error message, just silent fail (on a fresh install).
Comment 9 itsef-admin 2012-09-06 16:32:44 UTC
Just did another test, this time with the KDE4.9.0 packages from the Kubuntu Backports PPA: In 4.9.0, the error message IS shown, apparently.
Comment 10 Andrew Crouthamel 2018-09-23 02:32:04 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 11 Andrew Crouthamel 2018-10-27 04:01:49 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!