Bug 294548 - Keyboard navigation does no work with unread mails
Summary: Keyboard navigation does no work with unread mails
Status: RESOLVED FIXED
Alias: None
Product: kmail2
Classification: Applications
Component: general (show other bugs)
Version: 4.9.0
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-21 06:58 UTC by Axel Braun
Modified: 2012-09-28 13:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Axel Braun 2012-02-21 06:58:32 UTC
Version:           4.8 (using KDE 4.8.0) 
OS:                Linux

in a folder one can use arrow left/right to jump to the previous/next mail.
That does not work if unread mails are in the folder, e.g. after email-fetch in startup.
Once all mails are read, navigation works again.

Reproducible: Always

Steps to Reproduce:
see above


Expected Results:  
keyboard navigation works always
Comment 1 Laurent Montel 2012-07-27 17:44:59 UTC
Could you retest on 4.9 I fixed a lot of bug about it
Comment 2 Laurent Montel 2012-08-23 06:59:41 UTC
wait for info
Comment 3 Axel Braun 2012-08-23 07:30:05 UTC
I run now  4.9.00 "release 558" and notice that keyboard navigation mostly works, but I noticed now and then an 'hang', where Kmail does not navigate to the next message independent of read or unread. I will try to find a pattern to be able to give you information for debugging.
Comment 4 Axel Braun 2012-08-25 14:59:18 UTC
I noticed when I was offline that the keyboard navigation did not work.
All mails were read, one was just answered, and arrow-left/right did not work. When clicking with the mouse on a mail (to make sure the focus is right) it did not work either
Comment 5 David Faure 2012-09-27 16:26:27 UTC
I had similar issues with some actions having the wrong state (disabled when they should be enabled).

It turned out that this only happened in the following scenario:

Let's say you have your inbox in the favorites view. Click on another folder in the foldertree, ok.
Now click on the inbox in favorites view: this automatically selects the inbox in the foldertree, but it didn't set the current-index to that, so kmail wasn't informed of the new current folder, which broke the action states, and led to confusing keyboard navigation in the folder tree (Ctrl+left/right). (You can see the current index in the folder tree with the small line next to it when scrolling up/down, or using ctrl+space to select it.)

This could lead to your bug (next/prev message actions disabled, so arrow left/right not working) only if the "initial folder" was completely empty, but it's a possibility....

I'm about to commit the fix for that bug, please confirm if that was your bug, so that I can close this one or not.
Comment 6 Axel Braun 2012-09-27 18:51:41 UTC
(In reply to comment #5)
> Let's say you have your inbox in the favorites view. Click on another folder
> in the foldertree, ok.
> Now click on the inbox in favorites view: this automatically selects the
> inbox in the foldertree, but it didn't set the current-index to that, so
> kmail wasn't informed of the new current folder, which broke the action
> states, and led to confusing keyboard navigation in the folder tree
> (Ctrl+left/right). (You can see the current index in the folder tree with
> the small line next to it when scrolling up/down, or using ctrl+space to
> select it.)

Thats rigth, at that moment nothing works with the keyboard navigation. But even if I click into the messages list of one preferred folder, keyboard nav does not work
Comment 7 David Faure 2012-09-28 13:29:21 UTC
Git commit 21cd990881fd3bf0cf10061a2aab24edf2efe7a4 by David Faure.
Committed on 27/09/2012 at 18:29.
Pushed by dfaure into branch 'KDE/4.9'.

Fix synchronization between favorites view and folder tree in kmail.

1) ensure one slot doesn't call the other; the old blockSignals was meant
to do that, but that was wrong of course (the action manager doesn't
emit signals, it's connected to them)

2) set the current index in the folder tree, not just the selection,
so that keyboard navigation is more predictable, but more importantly
so that kmail is informed of the new current folder, and updates actions
appropriately.

M  +28   -6    akonadi/standardactionmanager.cpp