It does not really make sense for it to stay in systray when you go offline as you cannot accept/reject it anyway. Once you reconnect, it should appear again (which already does).
"Add Contact SNI" ? Do you mean the "Add New Contacts" button on the main widget ?
No, it means that the "Add Contact StatusNotifierItem", the systray icon, should be hidden once you go offline (or the account that it belongs to goes offline).
I'm working on this but running into problems. I tried asking on irc but couldn't get help except from mck182. Can we discuss possible solutions here ? Like I can show what I'm trying and someone could possibly nudge me in the right direction, if thats ok with you.
The bug tracker is not really the best place to show your ongoing work. If you have something that's working, please post the diff at http://git.reviewboard.kde.org and we'll all comment there and make suggestions. If you just need help, feel free to mail the mailing list (email@example.com), lots of very clever people are there or you can ping me on irc (mck182) and I'll do my best to help.
Please find a proposed patch at http://git.reviewboard.kde.org/r/104555/ though I think a lot more is required. Please provide your suggestions. I'll be digging deeper.
Review was closed for not really solving the issue.
If one account goes offline, the contacts for that account should be hidden.
We should monitor the ContactPtr->manager()->connection() for becoming invalidated, and remove the contact from the menu when this happens.
My KTp::Contact class (in review) has a handy signal for when the connection drops, if this merges it will make this fix a lot easier.
Created review request for a change that fixes this for me: https://git.reviewboard.kde.org/r/108846/
Git commit 6ed91fd966758a28260ae45ff909dd299cf5e1a9 by David Edmundson, on behalf of Stefan Eggers.
Committed on 08/02/2013 at 13:49.
Pushed by davidedmundson into branch 'master'.
When offline, hide the "add contact status notifier item"
DIGEST: Fixes having a notification "a new contact has added you" even when you are offline.
M +11 -0 contact-request-handler.cpp
M +1 -0 contact-request-handler.h
M +2 -1 telepathy-module.cpp