Bug 294460 - std namespace issue [patch]
Summary: std namespace issue [patch]
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Portability-Runtime (show other bugs)
Version: 2.5.0
Platform: Compiled Sources Solaris
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-20 00:20 UTC by tropikhajma
Modified: 2017-07-27 04:49 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 2.6.0
Sentry Crash Report:


Attachments
patch (1.45 KB, patch)
2012-02-20 00:20 UTC, tropikhajma
Details
patch (1.71 KB, patch)
2012-02-20 00:22 UTC, tropikhajma
Details
patch (2.74 KB, patch)
2012-02-20 00:33 UTC, tropikhajma
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tropikhajma 2012-02-20 00:20:45 UTC
Created attachment 68944 [details]
patch

Version:           2.5.0 (using KDE 4.8.0) 
OS:                Solaris

trying to build digikam 2.5 with the  fails with the below error.
the attached patch fixes it for me

Reproducible: Always

Steps to Reproduce:
try to build digikam

Actual Results:  
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/metadataedit/exif/exiflens.cpp", line 328: Error: The function "pow" must have a prototype.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/metadataedit/exif/exiflens.cpp", line 353: Error: The function "pow" must have a prototype.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/metadataedit/exif/exiflens.cpp", line 410: Error: The function "log" must have a prototype.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/metadataedit/exif/exiflens.cpp", line 410: Error: The function "log" must have a prototype.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/metadataedit/exif/exiflens.cpp", line 423: Error: The function "log" must have a prototype.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/metadataedit/exif/exiflens.cpp", line 423: Error: The function "log" must have a prototype.
6 Error(s) detected.
...
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/metadataedit/exif/exifdevice.cpp", line 496: Warning: data hides QWidget::data.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/metadataedit/exif/exifdevice.cpp", line 543: Error: The function "log" must have a prototype.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/metadataedit/exif/exifdevice.cpp", line 715: Error: The function "log" must have a prototype.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/metadataedit/exif/exifdevice.cpp", line 715: Error: The function "log" must have a prototype.
...
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/metadataedit/exif/exifdevice.cpp", line 543: Error: The function "exp" must have a prototype.


Expected Results:  
builds ok

Solaris Studio 12.3 compiler
Comment 1 tropikhajma 2012-02-20 00:22:02 UTC
Created attachment 68945 [details]
patch
Comment 2 tropikhajma 2012-02-20 00:33:15 UTC
Created attachment 68947 [details]
patch

this one for this failure:
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/printimages/tools/layouttree.cpp", line 129: Error: The function "sqrt" must have a prototype.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/printimages/tools/layouttree.cpp", line 130: Error: The function "sqrt" must have a prototype.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/printimages/tools/layouttree.cpp", line 133: Error: The function "sqrt" must have a prototype.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/printimages/tools/layouttree.cpp", line 134: Error: The function "sqrt" must have a prototype.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/printimages/tools/layouttree.cpp", line 160: Error: The function "sqrt" must have a prototype.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/printimages/tools/layouttree.cpp", line 161: Error: The function "sqrt" must have a prototype.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/printimages/tools/layouttree.cpp", line 168: Error: The function "sqrt" must have a prototype.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/printimages/tools/layouttree.cpp", line 169: Error: The function "sqrt" must have a prototype.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/printimages/tools/layouttree.cpp", line 376: Error: The function "sqrt" must have a prototype.
"/opt/test2/packages/BUILD/digikam-2.5.0/i386/digikam-2.5.0/extra/kipi-plugins/printimages/tools/layouttree.cpp", line 377: Error: The function "sqrt" must have a prototype.
10 Error(s) detected.
Comment 3 caulier.gilles 2012-02-20 08:02:40 UTC
Git commit f4c111ff5bdd5318409c50831f1003df8e740193 by Gilles Caulier.
Committed on 20/02/2012 at 09:02.
Pushed by cgilles into branch 'master'.

fix namespace issues

M  +2    -2    metadataedit/exif/exifdevice.cpp
M  +4    -4    metadataedit/exif/exiflens.cpp
M  +10   -10   printimages/tools/layouttree.cpp

http://commits.kde.org/kipi-plugins/f4c111ff5bdd5318409c50831f1003df8e740193