Bug 294295 - ktp-send-file.desktop installed in wrong directory
Summary: ktp-send-file.desktop installed in wrong directory
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Frameworks and Libraries
Component: send-file (show other bugs)
Version: 0.3.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 0.4.0
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-17 09:40 UTC by Daimonion
Modified: 2012-07-06 12:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daimonion 2012-02-17 09:40:35 UTC
Version:           0.3 (using KDE 4.8.0) 
OS:                Linux

ktp-send-file.desktop is installed in $PREFIX/share/applications/kde4, therefore displaying it in the menu, under the Lost&Found. It should be installed in $PREFIX/share/kde4/services/ServiceMenus, as it is a service menu.

Reproducible: Always

Steps to Reproduce:
Just compile and install ktp-send-file package.

Actual Results:  
ktp-send-file.desktop is installed in $PREFIX/share/applications/kde4

Expected Results:  
ktp-send-file.desktop should be installed in $PREFIX/share/kde4/services/ServiceMenus

Proposed fix:

Top-level CMakeLists.txt file, line 53:

 install(FILES ktp-send-file.desktop DESTINATION ${XDG_APPS_INSTALL_DIR})

should look something like this:

 install(FILES ktp-send-file.desktop DESTINATION ${SERVICES_INSTALL_DIR}/ServiceMenus)
Comment 1 David Edmundson 2012-02-18 13:19:02 UTC
Thanks.

It's not /just/ a service menu entry, if you launch it by hand, you get prompted for a file.

We could alternately specify the network folder so it appears in the start menu correctly instead of lost+found...or we could not have it in the menu at all and be a service menu only which means making the change above.

I'm not sure. Has anyone ever wanted to launch ktp-send-file from the start menu?
Comment 2 Daimonion 2012-02-18 13:26:07 UTC
ktp-send-file.desktop *is* a service menu file, it's place is in the (/usr/share/)kde4/services/ServiceMenus directory. If I launch it from the menu I get nothing. If you want to add posibility for a user to launch ktp-send-file from the menu, you should add another file (which is not of type "service") to the (/usr/share/)applications directory.
Comment 3 David Edmundson 2012-02-18 13:37:01 UTC
Git commit 47b1cc0b79bac4b6775ac0221e604006ad8ffa1c by David Edmundson.
Committed on 18/02/2012 at 14:35.
Pushed by davidedmundson into branch 'master'.

Fix ktp-send-file.desktop being installed in wrong directory

M  +1    -1    CMakeLists.txt

http://commits.kde.org/telepathy-send-file/47b1cc0b79bac4b6775ac0221e604006ad8ffa1c