Bug 293926 - Polling of solid and mtab for dynamic collections horribly broken
Summary: Polling of solid and mtab for dynamic collections horribly broken
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Collections/Local (show other bugs)
Version: 2.5.0
Platform: openSUSE Linux
: NOR normal
Target Milestone: 2.6
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-12 18:46 UTC by Stefan Brüns
Modified: 2012-09-28 07:53 UTC (History)
8 users (show)

See Also:
Latest Commit: http://commits.kde.org/amarok/92fe9ac171b9920ba65adf244c7dbe23d694d209
Version Fixed In: 2.7
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Brüns 2012-02-12 18:46:17 UTC 
+++ This bug was initially created as a clone of Bug #249760 +++
Currently, amarok polls for changes every second. This polling involves:
1. Reading and parsing mtab (via KMountpoint)
2. Reading and parsing fstab (via KMountpoint)
3. Querying solid for a list of all StorageAccess devices.

Especially the last point is problematic, as this involves querying UDisks, creating a huge number of DBus roundtrips.

A fix for solid s mtab monitoring is in reviewboard. After this is applied, the changes in MediaCache should be reverted.
Comment 1 Myriam Schweingruber 2012-02-14 11:34:30 UTC 
Could you please provide a link to that fix in reviewboard?
Comment 3 Stefan Brüns 2012-02-15 00:30:54 UTC 
https://git.reviewboard.kde.org/r/103954/ is the relevant request
Comment 4 Mario Bensi 2012-02-28 15:24:50 UTC 
Git commit b16cfec44104ded4a8959af4e790fe2f7d6d2745 by Mario Bensi.
Committed on 28/02/2012 at 16:22.
Pushed by bensi into branch 'KDE/4.8'.

Fix for mtab monitoring on Linux

Add a QSocketNotifier pointing to the mtab fd.

REVIEW: 103954
Related: bug 293914

M  +15   -1    solid/solid/backends/fstab/fstabwatcher.cpp
M  +4    -0    solid/solid/backends/fstab/fstabwatcher.h

http://commits.kde.org/kdelibs/b16cfec44104ded4a8959af4e790fe2f7d6d2745
Comment 5 Stefan Brüns 2012-09-27 10:23:12 UTC 
Fixed in 2.7

http://commits.kde.org/amarok/92fe9ac171b9920ba65adf244c7dbe23d694d209