Bug 293864 - Quick unmaximization not working with BorderlessMaximizedWindows=true
Summary: Quick unmaximization not working with BorderlessMaximizedWindows=true
Status: RESOLVED NOT A BUG
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: 4.8.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-11 21:46 UTC by Hans Chen
Modified: 2012-02-12 00:08 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Chen 2012-02-11 21:46:36 UTC
Version:           4.8.0 (using KDE 4.8.0) 
OS:                Linux

Windows do not unmaximize correctly when you have BorderlessMaximizedWindows=true and drag them (e.g. with Alt+left mouse button) in their maximized state. Instead of being restored and showing the window decoration, windows retain their maximized size with no window decoration.


Reproducible: Always

Steps to Reproduce:
1. Enable "Maximize windows by dragging them to the top of the screen" and BorderlessMaximizedWindows=true in kwinrc.
2. Maximize a window.
3. Try to move the window with Alt+left mouse button.

Actual Results:  
The window retains its size and no decoration.

Expected Results:  
The window should be restored to an unmaximized with a window decoration.

See also Bug 279529 after comment #10.
Comment 1 Thomas Lübking 2012-02-11 22:02:52 UTC
Works for me.
"kcmshell4 kwinoptions", "Moving tab", ensure "Display borders on maximized windows" is NOT checked. It simply collides with Quick maximization.

That won't fix easily, therefore i'm about to (proposingly) remove this setting and handle the "conflict" smarter.
Comment 2 Hans Chen 2012-02-11 22:26:34 UTC
I can confirm that that fixes it, thanks!

A suggestion from a user's point of view (might not make sense code-wise):
I don't associate "Display borders on maximized windows" with "Moving". Maybe there could be a setting in Advanced instead, something like

Maximized windows: [ Show titlebar and borders | Hide borders | Hide titlebar and borders ]

This would also fix Bug 268517.

Personally I don't use the "Display borders on maximized windows" option (no idea why it was checked...) and wouldn't be sad to see it go, but of course I can only talk for myself.
Comment 3 Thomas Lübking 2012-02-11 22:33:04 UTC
The setting has actually no relation to borders but controls whether a maximized window was still movable or not. The quick maximization was introduced and the setting got renamed towards a behavior often implemented in decorations (for fitt's law, ie. have the scrollbars on the screen edge)

The general idea for the future to have maximized windows always movable but with a strong snapping (ie. you have to try hard to get it moved) and always snap the window content to screen borders, never the decoration.

If quick maximizing is used, the window will just get unmaximized before you continue moving it.
Comment 4 Hans Chen 2012-02-12 00:08:54 UTC
That sounds like a nice solution to me. Thanks for all the help, and keep rocking!