Bug 293526 - Plasmoid does not monitor TextChannel:pendingMessagesRemoved()
Summary: Plasmoid does not monitor TextChannel:pendingMessagesRemoved()
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: chat-plasmoid (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: 0.4.0
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-07 13:11 UTC by David Edmundson
Modified: 2012-07-06 12:47 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Edmundson 2012-02-07 13:11:31 UTC
and as such shows unread messages, even when they've been cleared by another handler.
Comment 1 Lasath Fernando 2012-02-13 01:47:26 UTC
Git commit 1df722aa5c796647e87dfbc9690d63e1bf5c53f2 by Lasath Fernando.
Committed on 13/02/2012 at 02:32.
Pushed by fernando into branch 'master'.

The Delegate Channels Patch a.k.a David's massive patch

In the plasmoid:
Convert plasmoid to a handler from an observer
Support delegate channels (via a nasty hack currently)
Add popout button to delegate to main text UI
Merge the conversationsModel and handler into one class
Fix exposing a load of items to QML for no reason.
Some additional tidying. (and some additional messying :-) )
Clear unread messages on TextChannel::pendingMessagesRemoved()

In the textUI:
Always raise the window in the main Text UI handleChannel unless
 hint explicitly says otherwise.
Additionally fixes a bug in which reconnecting an account could
cause the tabs to 'randomly' switch.

REVIEW: 103908

M  +10   -3    app/chat-tab.cpp
M  +8    -10   app/telepathy-chat-ui.cpp
M  +13   -1    plasmoid/declarative-plugin/conversation.cpp
M  +6    -3    plasmoid/declarative-plugin/conversation.h
M  +74   -22   plasmoid/declarative-plugin/conversations-model.cpp
M  +13   -3    plasmoid/declarative-plugin/conversations-model.h
M  +0    -10   plasmoid/declarative-plugin/messages-model.cpp
M  +0    -3    plasmoid/declarative-plugin/messages-model.h
M  +0    -9    plasmoid/declarative-plugin/qml-plugins.cpp
M  +14   -51   plasmoid/declarative-plugin/telepathy-text-observer.cpp
M  +9    -7    plasmoid/declarative-plugin/telepathy-text-observer.h
M  +20   -3    plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml
M  +7    -9    plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml

http://commits.kde.org/telepathy-text-ui/1df722aa5c796647e87dfbc9690d63e1bf5c53f2