Bug 293479 - tab-close icon doesn't follow stock icon theme in almost all widget styles
Summary: tab-close icon doesn't follow stock icon theme in almost all widget styles
Status: RESOLVED FIXED
Alias: None
Product: Oxygen
Classification: Plasma
Component: style (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR minor
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-06 22:24 UTC by acidrums4
Modified: 2012-02-13 17:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Preview of the issue. (6.55 KB, image/png)
2012-02-06 22:24 UTC, acidrums4
Details

Note You need to log in before you can comment on or make changes to this bug.
Description acidrums4 2012-02-06 22:24:13 UTC
Created attachment 68577 [details]
Preview of the issue.

Version:           unspecified (using KDE 4.8.0) 
OS:                Linux

I know this must be the most ridiculous bug report of the history but I really don't like this behaviour.

I'm using Oxygen style and "KFaenza" icons. I've noticed that the icon in button for close a tab in apps like rekonq or Dolphin (not in Konsole, where that button is not inside tabs) doesn't follow the stock icon theme. There's displayed a little white X inside a red rounded square. I tried changing to every single widget style provided with my installation of KDE: CDE, Cleanlooks, Fase, "MS Windows 9x", Motif, Plastique and QtCurve. The only widget style that follows the icon theme is QtCurve. Every else widget style displays that red rounded square excepting Cleanlooks, which the icon in the tab-close button is a black script-like X.

I thought widget styles followed Oxygen icon theme by default for that icon, so I looked for that icon into Oxygen ones and didn't find it. Even in "hicolor" icon theme I couldn't find it, so I don't think is a problem about the icon theme.

I'm not sure but in KDE 4.7 that issue was fixed, in KDE 4.6 I saw the same issue.

Reproducible: Didn't try

Steps to Reproduce:
Set any of CDE, Cleanlooks, Fase, "MS Windows 9x", Motif, Oxygen and Plastique widget styles.

Actual Results:  
tab-close icon for closing tabs use a icon that not belongs to the icon theme.

Expected Results:  
tab-close icon for closing tabs should use the icon provided in the stock icon theme.

Preview attached and located in http://tinypic.com/r/ev470x/5: At the top there's showed two opened tabs in Dolphin, using Oxygen widget style and "KFaenza" icons. The same icon is showed for CDE, Fase, "MS Windows 9x", Motif and Plastique widget styles. At the middle is where I used Cleanlooks, and at the bottom is QtCurve, the only one that uses the icon from the stock theme.
Comment 1 Christoph Feck 2012-02-06 22:39:10 UTC
> I thought widget styles followed Oxygen icon theme by default

The close button graphics is not an icon, but an "element" of the style (same as checkboxes, arrows etc.)

It would be possible to add code to the Oxygen style to load an icon for the close button, but the next bug report would be about the checkbox or the arrow glyphs not be loaded from the icon set.

If you want a style with customizable graphics, look at http://kde-look.org/content/show.php/QuantumStyle?content=101088
Comment 2 acidrums4 2012-02-06 22:48:04 UTC
> It would be possible to add code to the Oxygen style to load an icon for the
> close button, but the next bug report would be about the checkbox or the arrow
> glyphs not be loaded from the icon set.

That doesn't make any sense, as far as I know icon themes doesn't have any icon for checkbox/arrow glyphs. But you're right about that those elements are drawn by widget styles. Why QtCurve doesn't do that?
Comment 3 Hugo Pereira Da Costa 2012-02-08 12:28:34 UTC
ok. In fact, I can reproduce, and only if blur is enabled.
Comment 4 Hugo Pereira Da Costa 2012-02-08 12:36:38 UTC
oops wrong bug
Comment 5 Hugo Pereira Da Costa 2012-02-13 17:26:04 UTC
Git commit eebc1a5ed1d60ca5a8df9ec221e5ad1aaca54dd7 by Hugo Pereira Da Costa.
Committed on 08/02/2012 at 15:31.
Pushed by hpereiradacosta into branch 'master'.

use dialog-close icon for tab close.

M  +27   -1    kstyles/oxygen/oxygenstyle.cpp
M  +6    -0    kstyles/oxygen/oxygenstyle.h

http://commits.kde.org/kde-workspace/eebc1a5ed1d60ca5a8df9ec221e5ad1aaca54dd7
Comment 6 acidrums4 2012-02-13 17:34:04 UTC
Thank you so much for fixing it!