Bug 292618 - OSD should show "0%" volume when muted
Summary: OSD should show "0%" volume when muted
Status: RESOLVED FIXED
Alias: None
Product: kmix
Classification: Applications
Component: On-Screen-Display (OSD) (show other bugs)
Version: 4
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Christian Esken
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-27 18:10 UTC by Ondrej Machulda
Modified: 2012-09-21 19:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
The percent should read 0 when muted. (10.97 KB, image/png)
2012-01-27 18:10 UTC, Ondrej Machulda
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ondrej Machulda 2012-01-27 18:10:12 UTC
Created attachment 68247 [details]
The percent should read 0 when muted.

Version:           4 (using KDE 4.8.0) 
OS:                Linux

When volume is muted, the OSD volume control should read "0%" instead of just changing the icon (which is also hard to recognize - see bug #292616)

Event though technically the volume value doesn't change when muting (just the mute flag is switched), the output from users point of view does, so this would be much more user friendly.

Reproducible: Always

Steps to Reproduce:
1. Mute or unmute volume
2. KMix OSD is shown
3. The volume percent value is not changed when muting/unmuting - see attachment


Expected Results:  
When volume is muted, the volume percent should be "0%". When it is unmuted, the original value should be restored.
Comment 1 Andrei ILIE 2012-09-09 13:12:43 UTC
Confirming this on KMix 4.1 using KDE 4.8.5.

SOLUTION - When muted, volume should be set to zero everywhere (dbus, OSD, KMix, etc) but its last value rememberd and restored on future unmuting action.

Possibly related reports:
      Bug 292616 - "Sound muted" icon is hard to recognize in OSD
Comment 2 Christian Esken 2012-09-20 11:07:37 UTC
I agree that it should be consistent in all GUI parts. But DBUS should return real values, as otherwise DBUS clients might work wrong, e.g. when implementing something like "volume-up-unmutes-sound".
Comment 3 Christian Esken 2012-09-21 19:42:29 UTC
Git commit 2c3aad0bd6929d237a2a2967532b9429760c2d82 by Christian Esken.
Committed on 21/09/2012 at 21:40.
Pushed by esken into branch 'master'.

Consistently show a volume level of 0% when muted.

M  +27   -29   gui/kmixdockwidget.cpp
M  +2    -0    gui/kmixdockwidget.h
M  +4    -0    gui/osdwidget.cpp

http://commits.kde.org/kmix/2c3aad0bd6929d237a2a2967532b9429760c2d82