Bug 292282 - Custom presence widget hides the spinning widget
Summary: Custom presence widget hides the spinning widget
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Frameworks and Libraries
Component: contactlist (show other bugs)
Version: git-latest
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-23 18:00 UTC by Daniele E. Domenichelli
Modified: 2013-03-03 17:44 UTC (History)
3 users (show)

See Also:
Latest Commit: http://commits.kde.org/telepathy-contact-list/19ebafedd3dea93aef6efeced15a9b2155b0cbbd
Version Fixed In: 0.6.0

Attachments
The cropped out spinner (3.27 KB, image/png)
2012-01-23 18:14 UTC, David Edmundson 		Details
screenshot (15.46 KB, image/png)
2012-01-23 18:27 UTC, Daniele E. Domenichelli 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Daniele E. Domenichelli 2012-01-23 18:00:32 UTC 
When the presence bar is clicked and changes to a line edit to set a custom presence, if the spinning widget is running is partially hidden (see attached screenshot)
Comment 1 Martin Klapetek 2012-01-23 18:04:06 UTC 
You forgot the screenshot. Nevertheless, I'm not really convinced this is a bug. In fact, I think this is a feature. When you start typing, the text would be hidden by the wheel, making it hardly readable.
Comment 2 David Edmundson 2012-01-23 18:05:20 UTC 
Maybe, but a half cropped crappy spinner isn't a feature.

Either all on or all off.

Also I no longer get the constant spinning wheel thanks to my awesome fix. Do you?
Comment 3 Martin Klapetek 2012-01-23 18:10:02 UTC 
I disagree.

If you'd hide it while spinning, it would create an "operation finished" impression, which is wrong. If you let over the lineedit, it covers the text. So visible in the background seems the best to me.

The lineedit serves basically as a modal dialog. If you open a modal dialog, it usually covers part of its parent window.
Comment 4 David Edmundson 2012-01-23 18:14:01 UTC 
Created attachment 68115 [details]
The cropped out spinner
Comment 5 David Edmundson 2012-01-23 18:14:38 UTC 
I agree with all the logic and sentiments, but I can't agree that the current situation looks nice.
Comment 6 Martin Klapetek 2012-01-23 18:22:23 UTC 
We could make the wheel shrink the lineedit then, so that the lineedit's width is less than the wheel's x value when the wheel is shown, make it full width when it's not.
Comment 7 Daniele E. Domenichelli 2012-01-23 18:27:20 UTC 
Created attachment 68116 [details]
screenshot
Comment 8 Daniele E. Domenichelli 2012-01-23 19:22:49 UTC 
(In reply to comment #2)
> Also I no longer get the constant spinning wheel thanks to my awesome fix. Do
> you?

yes, looks like it is fixed for me as well...
Comment 9 Daniele E. Domenichelli 2012-03-12 14:14:19 UTC 
Re-confirming that this is still present even with the new button to change the status, you could just hide the spinning animation while the presence bar is in edit mode
Comment 10 Roman 2013-03-03 11:21:52 UTC 
We can just change account status icon (green circle on the left) instead of drawing that spinning overlay.
Comment 11 Martin Klapetek 2013-03-03 11:36:52 UTC 
That won't be animated. However could be interesting moving the spinner over the presence icon, so it will look the same as the presence applet.
Comment 12 Roman 2013-03-03 17:41:46 UTC 
Git commit 19ebafedd3dea93aef6efeced15a9b2155b0cbbd by Roman Nazarenko.
Committed on 03/03/2013 at 17:10.
Pushed by romann into branch 'master'.

busyOverlay now hides if presence chooser is editable.

REVIEW: 109262

M  +16   -4    global-presence-chooser.cpp
M  +1    -0    global-presence-chooser.h

http://commits.kde.org/telepathy-contact-list/19ebafedd3dea93aef6efeced15a9b2155b0cbbd