Bug 292033 - [PATCH] Events list should not be populated while chat window active
Summary: [PATCH] Events list should not be populated while chat window active
Status: RESOLVED INTENTIONAL
Alias: None
Product: kopete
Classification: Unmaintained
Component: general (other bugs)
Version First Reported In: SVN
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-20 13:39 UTC by Cédric Bellegarde
Modified: 2013-10-30 10:22 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Fix issue (558 bytes, patch)
2012-01-20 13:40 UTC, Cédric Bellegarde 		Details
New patch version (1.09 KB, patch)
2012-02-02 14:52 UTC, Cédric Bellegarde 		Details
Show Obsolete (1) View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Cédric Bellegarde 2012-01-20 13:39:50 UTC 
Version:           SVN (using KDE 4.7.4) 
OS:                Linux

While in a conversation, kopete add pending messages to it's dbus interface...

This make this dockmanager plugin buggy:
http://kde-look.org/content/show.php/kopete+dockmanager?content=148009

Reproducible: Always

Steps to Reproduce:
Chat with a contact

Actual Results:  
$ qdbus org.kde.kopete /Kopete  org.kde.Kopete.contactProperties contact_id

pending_messages: <p>wsdfgsdf</p>
<p>fdqsf</p>
<p>dqsf</p>




Expected Results:  
Chat window is focused, so, there is no pending messages

Patch attached to fix this issue
Comment 1 Cédric Bellegarde 2012-01-20 13:40:18 UTC 
Created attachment 68036 [details]
Fix issue
Comment 2 Cédric Bellegarde 2012-01-20 16:11:36 UTC 
*** This bug has been confirmed by popular vote. ***
Comment 3 Christoph Feck 2012-01-26 16:00:30 UTC 
I have not looked at the full code, but looking at just the patch, it seems you are creating a memory leak when the event is not added anywhere.
Comment 4 Cédric Bellegarde 2012-02-02 14:52:34 UTC 
Created attachment 68434 [details]
New patch version

Fix memory leak
Comment 5 Lamarque V. Souza 2012-02-25 15:12:15 UTC 
I would like to know if this patch causes any regressions. For example, what kind of messages it prevent from being appended? Only contact conversion messages? does it prevent server messages ("another contact added you", "server is going offline", etc) from being appended as well?