Created attachment 67983 [details] patch Version: unspecified (using Devel) OS: Solaris src/plugins/declarative/RelatedActivities.cpp doesn't have a newline character after the last #include statement. the C++ standard requires it and the Studio compiler is strict about it, so the build fails. Reproducible: Always Steps to Reproduce: cd /opt/test2/packages/BUILD/marble-4.7.97/build-marble-4.7.97/src/plugins/declarative && /opt/test2/SolarisStudio12.3-solaris-x86-bin/solarisstudio12.3/bin/CC -DMarbleDeclarativePlugin_EXPORTS -DQT_USE_FAST_CONCATENATION -DQT_USE_FAST_OPERATOR_PLUS -DMARBLE_DBUS -DQT_GUI_LIB -DQT_CORE_LIB -DQT_NO_DEBUG -D__EXTENSIONS__ -DSOLARIS -DLDAP_DEPRECATED -library=stdcxx4 -D_REENTRANT -DNDEBUG -D__EXTENSIONS__ -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_POSIX_PTHREAD_SEMANTICS -DSOLARIS -DNO_DEBUG -D_UNICODE -DUNICODE -D_RWSTD_REENTRANT -D_XOPEN_SOURCE=500 -D_XPG5 -I/opt/kde4/include -features=extensions,nestedaccess,tmplrefstatic -template=geninlinefuncs -s -xlang=c99 -xustr=ascii_utf16_ushort -Qoption ccfe -features=gcc -Qoption ccfe -features=zla -Qoption ccfe ++boolflag:sunwcch=false -xbuiltin=%all -xinline=%auto -xprefetch=auto -xprefetch_auto_type=indirect_array_access -xprefetch_level=3 -KPIC -DPIC -xipo=0 -xO3 -xregs=no%frameptr -xjobs=2 -xrestrict=%all -xthreadvar=%all -z combreloc -z redlocsym -z nodefaultlib -z ignore -z now -z rescan -z absexec -xldscope=symbolic -xlibmil -s -m32 -xarch=sse2 -lc -lm -ldl -lpthread -lposix4 -lrt -Y P,/opt/kde4/lib -i -L/opt/kde4/lib -R/opt/kde4/lib -L/usr/lib -R/usr/lib -Bdynamic -library=stdcxx4 -lCrun -lc -lm -g -xO3 -DQT_NO_DEBUG -KPIC -I/opt/test2/packages/BUILD/marble-4.7.97/build-marble-4.7.97/src/plugins/declarative -I/opt/test2/packages/BUILD/marble-4.7.97/src/plugins/declarative -I/opt/test2/packages/BUILD/marble-4.7.97 -I/opt/test2/packages/BUILD/marble-4.7.97/src/lib -I/opt/test2/packages/BUILD/marble-4.7.97/src/lib/Projections -I/opt/test2/packages/BUILD/marble-4.7.97/src/lib/geodata -I/opt/test2/packages/BUILD/marble-4.7.97/src/lib/geodata/data -I/opt/test2/packages/BUILD/marble-4.7.97/src/lib/geodata/graphicsitem -I/opt/test2/packages/BUILD/marble-4.7.97/src/lib/geodata/handlers/dgml -I/opt/test2/packages/BUILD/marble-4.7.97/src/lib/geodata/parser -I/opt/test2/packages/BUILD/marble-4.7.97/src/lib/geodata/writer -I/opt/test2/packages/BUILD/marble-4.7.97/src/lib/geodata/scene -I/opt/test2/packages/BUILD/marble-4.7.97/src/lib/graphicsview -I/opt/test2/packages/BUILD/marble-4.7.97/src/lib/graphicsview/screengraphicsitem -I/opt/test2/packages/BUILD/marble-4.7.97/build-marble-4.7.97/src -I/opt/test2/packages/BUILD/marble-4.7.97/build-marble-4.7.97/src/lib -I/opt/test2/packages/BUILD/marble-4.7.97/src/plugins/declarative/src/plugins/declarative -I/opt/kde4/include -I/opt/kde4/include/QtGui -I/opt/kde4/include/QtCore -o CMakeFiles/MarbleDeclarativePlugin.dir/RelatedActivities.o -c /opt/test2/packages/BUILD/marble-4.7.97/src/plugins/declarative/RelatedActivities.cpp Actual Results: pkgbuild: "/opt/test2/packages/BUILD/marble-4.7.97/src/plugins/declarative/RelatedActivities.cpp", line 46: Error: There is extra text on this line. Expected Results: builds ok Solaris 11, Solaris Studio 12.3, x86
Git commit 49d2759d446860220a66ebaef855512353d5fca3 by Dennis Nienhüser. Committed on 19/01/2012 at 17:42. Pushed by nienhueser into branch 'master'. Fix build failure due to missing newline Patch by tropikhajma, thanks! M +1 -1 src/plugins/declarative/RelatedActivities.cpp http://commits.kde.org/marble/49d2759d446860220a66ebaef855512353d5fca3
Git commit dfac831eebb80704eb4c58e30e4a09fbd6bab15e by Dennis Nienhüser. Committed on 19/01/2012 at 17:42. Pushed by nienhueser into branch 'KDE/4.8'. Fix build failure due to missing newline Patch by tropikhajma, thanks! (cherry picked from commit 49d2759d446860220a66ebaef855512353d5fca3) M +1 -1 src/plugins/declarative/RelatedActivities.cpp http://commits.kde.org/marble/dfac831eebb80704eb4c58e30e4a09fbd6bab15e