Bug 291906 - -Wall etc. not supported by Solaris compiler
Summary: -Wall etc. not supported by Solaris compiler
Status: RESOLVED FIXED
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Solaris
: NOR normal
Target Milestone: 1.3 (KDE 4.8)
Assignee: marble-bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-18 22:34 UTC by tropikhajma
Modified: 2012-01-19 16:50 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
patch (821 bytes, patch)
2012-01-18 22:34 UTC, tropikhajma 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description tropikhajma 2012-01-18 22:34:58 UTC 
Created attachment 67982 [details]
patch

Version:           unspecified (using Devel) 
OS:                Solaris

the top level CMakeLists.txt uses -W* options for any non-MSVC compilers.
This breaks build with the Solaris Studio 12.3 compiler (earlier Studio versions ignored the -W flags)

the attached patch uses condition taken from akonadi instead

Reproducible: Always

Steps to Reproduce:
try to build it

Actual Results:  
fails

Expected Results:  
builds

Solaris 11, Solaris Studio 12.3, x86
Comment 1 Dennis Nienhüser 2012-01-19 16:45:28 UTC 
Git commit c7a5999d41f48da246e2882034cf08bdb74ecfc6 by Dennis Nienhüser.
Committed on 19/01/2012 at 17:40.
Pushed by nienhueser into branch 'master'.

Fix -Wall etc. not supported by Solaris compiler
Patch by tropikhajma, thanks!

M  +2    -2    CMakeLists.txt

http://commits.kde.org/marble/c7a5999d41f48da246e2882034cf08bdb74ecfc6
Comment 2 Dennis Nienhüser 2012-01-19 16:50:11 UTC 
Git commit 05b62fcfc4528109bd6b7d06b7baee7fbeae1a03 by Dennis Nienhüser.
Committed on 19/01/2012 at 17:40.
Pushed by nienhueser into branch 'KDE/4.8'.

Fix -Wall etc. not supported by Solaris compiler
Patch by tropikhajma, thanks!
(cherry picked from commit c7a5999d41f48da246e2882034cf08bdb74ecfc6)

M  +2    -2    CMakeLists.txt

http://commits.kde.org/marble/05b62fcfc4528109bd6b7d06b7baee7fbeae1a03