Bug 291445 - Expand groups when filtering contactlist
Summary: Expand groups when filtering contactlist
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Frameworks and Libraries
Component: contactlist (show other bugs)
Version: git-latest
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-13 13:50 UTC by Elias Probst
Modified: 2013-03-04 16:08 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elias Probst 2012-01-13 13:50:49 UTC
Version:           git-latest (using Devel) 
OS:                Linux

When filtering the contactlist
- groups containing matches should be expanded
- empty groups should be hidden

Reproducible: Didn't try



Expected Results:  
.
Comment 1 Martin Klapetek 2012-01-13 13:55:34 UTC
Additional note:

When the filtering is initiated, it shows all users (including offline), therefore showing all groups. But as the filtering advances (user inputs more chars), these users get hidden again, so simple addition to the proxy model {s|c}ould do the trick.

Also drdanz noted that during filtering all groups should be expanded (me adds: or at least definitly the one with the matching contact).
Comment 2 Dominik Cermak 2012-06-29 16:50:35 UTC
The hiding part is done (it will be in 0.5). Now only expanding is missing.
http://commits.kde.org/telepathy-common-internals/3737f85af335b0634d31c7d82a0e222f3475581c
Comment 3 David Edmundson 2013-01-15 17:14:12 UTC
Would it make sense to just go the flat list when searching? 

It'd be very simple in terms of code, and I think quite good from a user perspective.
(FWIW, Empathy does this)
Comment 4 Roman 2013-03-04 16:08:28 UTC
Git commit d51cfecf25b35599d9603a7e4ff163b95da806b4 by Roman Nazarenko.
Committed on 04/03/2013 at 14:12.
Pushed by romann into branch 'master'.

Contact list grouping now goes disabled during search.

REVIEW: 109280

M  +7    -1    contact-list-widget.cpp
M  +12   -10   contact-list-widget_p.h

http://commits.kde.org/telepathy-contact-list/d51cfecf25b35599d9603a7e4ff163b95da806b4