Bug 290937 - Text shapes dissappear on saving
Summary: Text shapes dissappear on saving
Alias: None
Product: krita
Classification: Applications
Component: Tools (show other bugs)
Version: git master (please specify the git hash!)
Platform: Chakra Linux
: NOR critical
Target Milestone: ---
Assignee: Krita Bugs
Depends on:
Reported: 2012-01-08 05:19 UTC by Kubuntiac
Modified: 2012-05-15 08:56 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:

KRA file which had two text shapes and a vector curve shape added before saving (11.49 KB, application/octet-stream)
2012-01-08 05:19 UTC, Kubuntiac
KRA file with glitching text (7.64 KB, application/octet-stream)
2012-01-28 17:58 UTC, Kubuntiac
SCreen grab of moving the text shape (245.61 KB, image/png)
2012-01-28 17:59 UTC, Kubuntiac

Note You need to log in before you can comment on or make changes to this bug.
Description Kubuntiac 2012-01-08 05:19:18 UTC
Created attachment 67565 [details]
KRA file which had two text shapes and a vector curve shape added before saving

Version:           svn trunk (using KDE 4.7.4) 
OS:                Linux

Text shapes do not appear to be saving / loading correctly. Most of the time when I reload a KRA that had a text shape, the text shape has simply disappeared, although sometimes it will load a question mark with a box around it (see attached kra file). The Vector layer it was on still exists. Changing the visibility of the layer off and on doesn't help. Vector curves seem to save/load just fine.

Reproducible: Always

Steps to Reproduce:
1. Create a new custom file (default settings)
2. Choose the text tool and drag somewhere on Canvas to create text.
3. Save the file.
4. Open the saved file.

Actual Results:  
The text's vector layer still exists, but the text shape itself does not appear

Expected Results:  
Text shape appears as it did before saving.

OS: Linux (x86_64) release 3.1-CHAKRA
Compiler: gcc
Krita revision: v2.3.85-474-g2215d10
Comment 1 LukasT 2012-01-26 09:54:05 UTC
Le me look at the bug
Comment 2 LukasT 2012-01-27 07:34:48 UTC
Git commit 3f8f315b83e296f41340a36767425c2983d230a6 by Lukáš Tvrdý.
Committed on 26/01/2012 at 18:53.
Pushed by lukast into branch 'master'.

Fix loading of the text shape

Manifest file was not parsed. Mimetype from manifest
is used for determining the correct shape factory.
As this information was not present, the shape could
not be identified and sometimes it was UnavailShape
or nothing.

This could possibly fix loading of ODG files in Krita too.

M  +3    -0    libs/odf/KoOdfLoadingContext.cpp

Comment 3 LukasT 2012-01-27 07:36:43 UTC
I fixed the loading. Now the saving is broken somehow.
There is still '?' shape instead of text shape on layer with the vector path. The problem is now in saving.

Can you try to recreate some document and describe the steps that lead to broken text shape?
Comment 4 Kubuntiac 2012-01-28 17:58:56 UTC
Created attachment 68279 [details]
KRA file with glitching text
Comment 5 Kubuntiac 2012-01-28 17:59:56 UTC
Created attachment 68280 [details]
SCreen grab of moving the text shape

Ok, so I tried this again.

Now when I load the file, it doesn't show a ? any more, however it also only shows one small cropped rectangle of the overall text. I can move the rectangle, and it leaves a trail, like it's not redrawing the background as it's moved.

I'll attach the original .kra file and a screengrab.

Calligra v2.3.85-966-g82fe970
Comment 6 Kubuntiac 2012-01-28 18:00:31 UTC
I just followed the steps to reproduce listed in the original report.
Comment 7 LukasT 2012-02-08 10:18:27 UTC
I can't reproduce it on Fedora, deevad tested on Kubuntu 11.10.

Loading should be fine. Saving might have a bug, but I don't know the steps to create the corrupted document (thus '?' shape displayed) attached as "KRA file which had two text shapes and a vector curve shape added before saving".

You can still reproduce the problem with loading/saving?
Are you able to create again the document "KRA file which had two text shapes and a vector curve shape added before saving"?

Glitching should be filled as separate bug report.
Comment 8 Dmitry Kazakov 2012-02-08 11:35:03 UTC
Works for me on OpenSUSE 11.4. Tested on Latin and Russian letters. It saves and loads.

The only trouble is, I cannot create a textshape by clicking with the text tool on the canvas. I have to drag a textshape from "Add Shape" docker. Probably, this is the reason of the success.