Version: 2.5.0 (using KDE 4.7.4) OS: Linux The gamut diagram can be resized horizontally by resizing the right panel. However, you cannot resize it vertically. Reproducible: Didn't try Expected Results: We should be able to resize it vertically by dragging the top of the box up. http://i.imgur.com/QIuIe.png
http://i.imgur.com/QIuIe.png I tried to make it bigger so I can take a nice screenshot of it (until the feature request for saving it to disk gets implemented) but I cannot resize it vertically, so it's very disproportionate.
Oops, wrong url for previous comment #1, here's the correct one: http://i.imgur.com/ZEtqD.png
Still cannot resize vertically in 3.0.0
Still valid for 4.2.0.
Maik, Current implementation of CIETongueWidget is voluntary limited to resize content horizontally. It's a limitation in rules from preview widget plug in image properties sidebar. It's not a limitation of widget as well. Widget can be re-sized vertically of course. I propose to use QScrollArea to host this widget and to permit to zoom in/out and pan over ICC profile content. What do you think about ? Gilles
Gilles, I find the best representation for the CIETongueWidget is square. What do you think? diff --git a/libs/widgets/iccprofiles/cietonguewidget.cpp b/libs/widgets/iccprofiles/cietonguewidget.cpp index 6c87e59..f309f4f 100644 --- a/libs/widgets/iccprofiles/cietonguewidget.cpp +++ b/libs/widgets/iccprofiles/cietonguewidget.cpp @@ -811,6 +811,8 @@ void CIETongueWidget::paintEvent(QPaintEvent*) void CIETongueWidget::resizeEvent(QResizeEvent* event) { Q_UNUSED(event); + + setMinimumHeight(width()); d->needUpdatePixmap = true; } Maik
The best representation depends on the shape of the gamut and on the needs of the user.
Maik, The square aspect ratio can be a good compromise as touch in code is very small... At least it's better than previous solution which is not very elegant... Gilles
I agree that it's an improvement and probably good enough.
Created attachment 92561 [details] splitter.png Or insert a splitter and the user can change the size? The state of the splitter would be probably saved. Maik
I tried square auto resize, and it's perfect and enough. Gilles
Git commit 3ccf141ec47ffca4fd7f7a1b2d3929c74ac6ec3a by Maik Qualmann. Committed on 13/05/2015 at 10:35. Pushed by mqualmann into branch 'master'. set CIETongueWidget to square view FIXED-IN: 4.11.0 M +2 -1 NEWS M +1 -0 libs/widgets/iccprofiles/cietonguewidget.cpp http://commits.kde.org/digikam/3ccf141ec47ffca4fd7f7a1b2d3929c74ac6ec3a
Git commit fedad652d305032959a45f626f5bd49c031a9e50 by Gilles Caulier. Committed on 13/05/2015 at 11:47. Pushed by cgilles into branch 'frameworks'. backport commit #3ccf141ec47ffca4fd7f7a1b2d3929c74ac6ec3a from git/master to frameworks branch M +1 -0 libs/widgets/iccprofiles/cietonguewidget.cpp M +1 -1 libs/widgets/iccprofiles/cietonguewidget.h http://commits.kde.org/digikam/fedad652d305032959a45f626f5bd49c031a9e50