Bug 290927 - Color management does not apply change and refresh the current preview image
Summary: Color management does not apply change and refresh the current preview image
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: ColorManagement-Views (show other bugs)
Version: 2.5.0
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-08 03:14 UTC by DrSlony
Modified: 2022-02-01 11:31 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.8.0
Sentry Crash Report:


Attachments
No color profile information. (342.78 KB, image/jpeg)
2012-01-08 03:14 UTC, DrSlony
Details
RT_sRGB color profile (342.87 KB, image/jpeg)
2012-01-08 03:15 UTC, DrSlony
Details

Note You need to log in before you can comment on or make changes to this bug.
Description DrSlony 2012-01-08 03:14:48 UTC
Created attachment 67560 [details]
No color profile information. 

Version:           2.5.0 (using KDE 4.7.4) 
OS:                Linux

If you enable/disable and apply color management, digiKam should update the photo you are viewing with the change. It doesn't. You have to click on another photo and back to this one to see the difference.

Reproducible: Always

Steps to Reproduce:
1- Disable color management
2- Click on a photo with a non-sRGB color profile (so that you can see the difference, as sRGB will be assumed if the profile metadata is missing from the photo)
3- Enable color management and apply it
4- You should see the colors change, but they don't.
5- Click on another photo and back to this one. Now you can see what it should look like with color management.


Expected Results:  
digiKam should refresh the preview when you enable or disable color management the moment you hit apply.
Comment 1 DrSlony 2012-01-08 03:15:35 UTC
Created attachment 67561 [details]
RT_sRGB color profile
Comment 2 DrSlony 2012-01-08 03:17:08 UTC
With no color management, these two attached photos will look identical. With color management enabled, noicm.jpg will appear lighter than the RT_sRGB.jpg photo.
Comment 3 Dik Takken 2012-07-03 07:53:46 UTC
Also, when you change display profiles, they are not applied immediately. You need to close DigiKam, load it again, and only then the new display profile is in effect.
Comment 4 Marcel Wiesweg 2012-07-21 13:31:21 UTC
Git commit b2754413698a001b38ef44874869c9f73dbe8bf3 by Marcel Wiesweg.
Committed on 21/07/2012 at 15:29.
Pushed by mwiesweg into branch 'master'.

If color management settings change, reload the preview image.

M  +2    -1    NEWS
M  +14   -0    libs/widgets/graphicsview/dimgpreviewitem.cpp
M  +2    -0    libs/widgets/graphicsview/dimgpreviewitem.h

http://commits.kde.org/digikam/b2754413698a001b38ef44874869c9f73dbe8bf3