Bug 290634 - Cannot accept contact authorization request
Summary: Cannot accept contact authorization request
Status: RESOLVED WORKSFORME
Alias: None
Product: telepathy
Classification: Unmaintained
Component: kded-module (show other bugs)
Version: git-latest
Platform: Unlisted Binaries Linux
: NOR grave
Target Milestone: 0.4.0
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-04 21:42 UTC by Daniele E. Domenichelli
Modified: 2015-07-31 16:16 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniele E. Domenichelli 2012-01-04 21:42:54 UTC
Using haze-msn I get the authorization request in the system tray, but when I click on authorize I get a "success" popup, but the contact is not really added.

The problem is in contact-request-handler.cpp:281
// If needed, reiterate the request on the other end
if (contact->manager()->canRequestPresenceSubscription() &&
    contact->subscriptionState() == Tp::Contact::PresenceStateNo) {
    connect(contact->manager()->requestPresenceSubscription(QList< Tp::ContactPtr >() << contact),
            SIGNAL(finished(Tp::PendingOperation*)),
            this, SLOT(onFinalizeSubscriptionFinished(Tp::PendingOperation*)));
}

Removing the "if" I was able to accept the request, but now I'm no longer able to reproduce this, because the contact was added, and I don't understand why.
Comment 1 Florian Reinhard 2012-01-05 23:49:34 UTC
I can confirm that adding new contacts didn't work propperly aswell with xmpp/gabble.
Comment 2 Martin Klapetek 2012-01-22 15:52:11 UTC
I'm able to confirm requests with both gtalk/gabble, xmpp/gabble and yahoo/haze.

In any case, I'm removing the 0.3 dep as it was not done in time and adding 0.4 instead. If it was fixed already, please close it.

We can have "known issues" in the release announcement, though it works for me.
Comment 3 Rich Johnson 2012-02-28 23:49:25 UTC
I really didn't want to create another bug report for the opposite command in the group. Deny. It doesn't work for me.

Kubuntu 12.04
kde-telepathy: 0.3.0

If you want me to do this the proper way, let me know and I will file a separate report
Comment 4 Daniele E. Domenichelli 2012-02-29 15:25:15 UTC
We will need to spend some time to fix the authorization request before 0.4
Comment 5 Raymond Wooninck 2012-05-08 10:07:50 UTC
What is currently the status and more important the planning with which release this is going to be solved?  

I am running the latest snapshot from git master, but I am still seeing the same problem.  At least on the Deny part. Currently I have to deny the same requests on a daily basis (most of them from spam users).
Comment 6 Martin Klapetek 2012-05-08 10:57:02 UTC
I would like to get this fixed for 0.4, I'll do some digging in the forthcoming days.
Comment 7 David Edmundson 2012-05-17 11:00:26 UTC
Closing as this contains no useful information here whatsoever.

If you still encounter an issue:
 - be absolutely sure to tell us which protocol you're using
 - open a different bug for accepting/denying
 - attach the gabble/haze log as explained here http://community.kde.org/Real-Time_Communication_and_Collaboration/FAQ#Providing_debug