Bug 290504 - Can't add new beams to custom plots - possible regression
Summary: Can't add new beams to custom plots - possible regression
Status: RESOLVED FIXED
Alias: None
Product: ksysguard
Classification: Applications
Component: ksysguard (show other bugs)
Version: 4.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
: 298640 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-01-03 15:25 UTC by Francesco Presel
Modified: 2019-03-11 11:45 UTC (History)
11 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Proposed patch (1.20 KB, patch)
2012-02-17 15:48 UTC, Simon Kaczor
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Francesco Presel 2012-01-03 15:25:56 UTC
Version:           4.0 (using Devel) 
OS:                Linux

KDE 4.8RC1 - Linux x86-64 - Kubuntu 11.10

When trying to create a single graph displaying multiple beams, it was impossible to add a second beam after the first one had been created. Moreover, the area where I could drop the first sensor was quite small: I had to drop the sensor exactly on the "drop here" text, or in a small area below that text and/or to the right of it. Dragging the sensor onto the graph did not make that beam appear, even if the cursor had the green + symbol which shows that the area where I was dragging it was allowed.
The only way to create multiple beam displays is to save, manually edit (via text editor) and load again the tab in a .sgrd file

Reproducible: Always

Steps to Reproduce:
Open ksysguard; select File>New Tab.
Inside the sensor browser on the right, expand for instance Memory->Physical Memory; drag two different indicators (eg, cached and buffers) to the same empty space.
The bug happens for any couple of sensors; the ones I listed are just an example.

Actual Results:  
The first beam is only displayed if you drag its sensor over the "release sensor here" text or to the bottom-right of it.
The second one is never displayed, in whatever area of the existing plot (or around it) you drop the sensor.

Expected Results:  
Until 4.7.*, You could drop the sensor anywhere in the area around the text, and the graphic would appear; after that, any other sensor could be dropped over an existing graphic and after that, both beams were shown on the same graph.
Comment 1 Travis Evans 2012-02-06 00:12:22 UTC
Confirmed on KDE 4.8.0 on Arch.  It is apparently impossible to add more than one sensor to a display like it was in KDE 3.5.10's Ksysguard.  This unfortunately makes it quite a bit less useful.
Comment 2 Simon Kaczor 2012-02-17 15:48:09 UTC
Created attachment 68870 [details]
Proposed patch
Comment 3 Simon Kaczor 2012-02-17 15:49:49 UTC
I am not project member, but here is a git patch that addresses the problem with dropping the second sensor.
Comment 4 Maik Beckmann 2012-02-18 16:03:45 UTC
Same for the line graph

% kde4-config --version
Qt: 4.8.0
KDE Development Platform: 4.8.00 (4.8.0
kde4-config: 1.0

Hm, looks like this output is buggy as well :P
Comment 5 kostas213@gmail.com 2012-03-02 17:51:56 UTC
Dedected also at KDE 4.8 on Arch. It worked on 4.7 as I remember.
Comment 6 Adam Porter 2012-03-03 20:20:28 UTC
Yes, confirmed on Kubuntu PPA 4.8.0.
Comment 7 Szczepan Hołyszewski 2012-04-26 01:12:54 UTC
Also confirmed on Arch, KDE 4.8.2. Please, everyone affected duly add your votes!
Comment 8 Martin Tlustos 2012-05-22 09:23:28 UTC
Confirmed on Kubuntu 12.04 with standard repos.
Comment 9 Martin Runge 2012-05-26 13:20:39 UTC
Confirmed on Kubuntu 12.04 using kde 4.8.3
Comment 10 Adam Porter 2012-05-30 06:42:50 UTC
This makes System Monitor nearly useless.  What's the point of having
that huge list of sensors if one can't use them?  :(
Comment 11 matemaciek 2012-05-30 06:53:37 UTC
Workaround: create multiple graphs, export tab to file, edit file in your favourite editor so that all sensors are on one graph, import tab from modified file. Annoying, but works.
Comment 12 John Tapsell 2012-06-06 22:01:50 UTC
Git commit 4ccec1a6623426ad7b3672ce85424ad9201e5b73 by John Tapsell.
Committed on 07/06/2012 at 00:00.
Pushed by johnflux into branch 'KDE/4.8'.

Fix regression that you couldn't add new beams to custom plots

Thanks to Simon Kaczor for the patch

M  +2    -4    ksysguard/gui/WorkSheet.cpp

http://commits.kde.org/kde-workspace/4ccec1a6623426ad7b3672ce85424ad9201e5b73
Comment 13 John Tapsell 2012-06-06 22:04:16 UTC
Git commit 3d99205dd59857631e9c271f1df9ebbd61926ad6 by John Tapsell.
Committed on 07/06/2012 at 00:00.
Pushed by johnflux into branch 'master'.

Fix regression that you couldn't add new beams to custom plots

Thanks to Simon Kaczor for the patch

M  +2    -4    ksysguard/gui/WorkSheet.cpp

http://commits.kde.org/kde-workspace/3d99205dd59857631e9c271f1df9ebbd61926ad6
Comment 14 Richard Llom 2019-03-11 11:45:15 UTC
*** Bug 298640 has been marked as a duplicate of this bug. ***