Bug 290155 - konversation requires qt3 support, but does not check for it
Summary: konversation requires qt3 support, but does not check for it
Status: RESOLVED INTENTIONAL
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: 1.4
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-30 09:34 UTC by Treeve Jelbert
Modified: 2013-04-15 02:25 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Treeve Jelbert 2011-12-30 09:34:51 UTC 
Version:           1.4
OS:                Linux

some parts of konversation reference qt3 support functions

$ git grep \<Q3

src/irc/nickinfo.cpp:#include <Q3MimeSourceFactory>
src/linkaddressbook/kimiface.h:#include <Q3CString>
src/viewer/viewtree.cpp:#include <Q3Header>
src/viewer/viewtree.cpp:#include <Q3DragObject>
src/viewer/viewtree.cpp:#include <Q3ListView>
src/viewer/viewtreeitem.h:#include <Q3ListView>

CMakeLists.txt does not check for QT_QT3SUPPORT_INCLUDE_DIR


Reproducible: Always

Steps to Reproduce:
compile konversation on a system without qt3support

Actual Results:  
build fails

Expected Results:  
build succeeds, konversation runs with restricted functionality

check for qt3support, disable modules which require it

alternatively, rewrite the offending code
Comment 1 Thomas Capricelli 2012-01-02 22:30:48 UTC 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


may i dare say ? This is the preferred way  :-)


On 30/12/2011 10:34, Treeve Jelbert wrote:
> alternatively, rewrite the offending code

- -- 
Thomas Capricelli <orzel@freehackers.org>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk8CMBMACgkQhAycqK0gnKvmswCgnYWKq6e5PWsN+bfAHT2hbSu4
+uwAn000wwFkk+D6BtwUmvKqZXj0iJaM
=d1I0
-----END PGP SIGNATURE-----
Comment 2 Eike Hein 2013-04-15 02:25:33 UTC 
Cleaning this out, we won't do build system work for this at this point as the aim is to eliminate the qt3support-using code indeed, and the lack of a check just hasn't been a problem in practice outside of this one report.