Bug 289850 - Size column uses KiB only
Summary: Size column uses KiB only
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: general (show other bugs)
Version: 1.99
Platform: Unlisted Binaries Linux
: NOR wishlist
Target Milestone: ---
Assignee: Peter Penz
URL:
Keywords:
: 295487 297380 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-12-26 12:42 UTC by markuss
Modified: 2012-04-09 10:00 UTC (History)
16 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.8.3


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description markuss 2011-12-26 12:42:31 UTC
Version:           1.99 (using Devel) 
OS:                Linux

The Size column in Details view always displays file sizes in KiB, even if a file is several GiB in size.

Reproducible: Always

Steps to Reproduce:
Switch to Details view

Actual Results:  
displays file sizes in KiB

Expected Results:  
A 1.3 MiB file should display 1.3 MiB. Same with GiB and beyond.
Comment 1 Christoph Feck 2012-01-05 17:24:46 UTC
I think the idea for the change was to immediately see large files (the more digits, the larger the file). With the thousands separators, it is also quite easy to read the MB or GB size, but I am not sure if those are automatically enabled in all locales.
Comment 2 Christoph Feck 2012-01-05 17:29:07 UTC
KSysGuard solves this quite nicely. Right-clicking on a size column gives you options for "mixed, KB, MB, GB". For Dolphin, I would definitively like to see a simple "bytes" option, too. Sometimes I would like to know which of two files is larger by a few bytes (e.g. when comparing compression efficiency).
Comment 3 Peter Penz 2012-01-05 18:15:39 UTC
I'm open here for any input, but I did not want to add an option before getting a feeling about how many people request it. I'd say let's wait until Dolphin 2.0 is out to get some further feedback.
Comment 4 Maxime Chassagneux 2012-01-27 12:12:51 UTC
In the list view I don't understand why the user see the size of a file with only the Kib unit, it's not realy "UserFriendly". 
If you want to see which file is bigger than a other, You have just to sort the column, and for a better information ( exact size ) the user could just show the properties windows for a specif file.
Please, change this behaviour and display the size file with the good unit (Tib, Mib, Kib etc... )
Comment 5 Alberto Mattea 2012-01-28 11:55:50 UTC
I'd also like so see an option for this. Having often files ranging from a few kilobytes to several gigabytes it is not really easy to read numbers like 10,485,760 at a glance...

Thanks

PS a quick idea: what about displaying the size (or the background of the size) using a gradient, for example pure black for <4Kib, intermediate colors in the middle and pure red for >1Gib so that big files are immediatly evident?
Comment 6 Nikita Skovoroda 2012-01-28 22:23:41 UTC
> what about displaying the size (or the background of the size)
using a gradient, for example pure black for <4Kib, intermediate colors in the
middle and pure red for >1Gib so that big files are immediatly evident?

That sounds awful.

Size is not that important to draw all the users attention to it by making it red-colored.

If you want a way to visually compare files by size, there already is filelight, filelightpart, and fsviewpart.
Comment 7 Nikita Skovoroda 2012-01-28 22:26:51 UTC
> KSysGuard solves this quite nicely. Right-clicking on a size column gives you options for "mixed, KB, MB, GB". For Dolphin, I would definitively like to see a simple "bytes" option, too. Sometimes I would like to know which of two files is larger by a few bytes (e.g. when comparing compression efficiency).

That sounds perfect, this is what i want to see :-)
Comment 8 Eike Hein 2012-01-30 12:34:31 UTC
FYI, we're seeing relatively frequent requests for megabytes and gigabytes in #kde on IRC.
Comment 9 Dennys 2012-01-31 21:08:17 UTC
Thanks for the Info! @ Eiki

> > KSysGuard solves this quite nicely [...]
> That sounds perfect, this is what i want to see :-)

yeah, me too :)
so everybody can use his individual preference...
Comment 10 Martux 2012-02-01 21:51:05 UTC
Please, restore the old behavior or make it selectable.
Comment 11 Alexander Kiselyov 2012-02-02 15:22:17 UTC
Well, that's a really bad idea of displaying only KiB's when you have both very small and large files in the same folder (e.g. a film and a text description).
Comment 12 Victor Garcia 2012-02-06 00:20:10 UTC
Wow, it comes as a shock to me that the behaviour has been modified to show only KiB..
I wonder who thought that was a good idea?

Anyway, voted. I also would like to have Dolphin smartly decide whether to use KiB, MiB, etc. or at least give us an option to enable/disable it.
Comment 13 Peter Penz 2012-02-06 08:49:23 UTC
@all: Thanks for your feedback, I'll add an option for this to be able to configure between Bytes, Kilobytes, Megabytes and "mixed" (like before). As the question has been raised several times why this had been changed: There had been quite a lot complaints from users when we introduced the "mixed" sizes in KDE 4.0 and those people wanted to have back one unit like e.g. in KDE 3 or Midnight Commander. However this seems to be a very controversial topic where obviously different people prefer different settings -> option.
Comment 14 adrian 2012-02-06 13:10:42 UTC
Peter, thank you for all you do but I do not think that reverting to some old style display system was a good idea.
Dolphin is a modern app and it is logical to act "smart" and decide the proper prefix to use.

Don't intend to be mean but the ones who don't know what a GiB is, should go back to grade school or continue using MC. What will happen when we have TiB sizes? display a 9 digit number?

I sincerely thing that adding an option for this is just a waste of coding.

Option or not please make it display smart again.

Adrian
Comment 15 Victor Garcia 2012-02-07 11:52:59 UTC
Great news.

Thank you Peter.

@Adrian, if its not too much work and they are willing to do it, I think it is always a good thing to give the option.
If, as Peter says, there are people who requested reverting back to the 3.X behaviour, then I say give them the option to do so.
Comment 16 Peter Penz 2012-03-07 18:46:07 UTC
*** Bug 295487 has been marked as a duplicate of this bug. ***
Comment 17 Peter Penz 2012-04-03 14:22:01 UTC
*** Bug 297380 has been marked as a duplicate of this bug. ***
Comment 18 Peter Penz 2012-04-09 07:50:40 UTC
Git commit 99f4637da7cde6fb76816c43563700dceeb06e48 by Peter Penz.
Committed on 09/04/2012 at 09:44.
Pushed by ppenz into branch 'master'.

Revert the 2.0 decision to always use KB for file-sizes

The feedback on bugs.kde.org has shown that the previous behavior
(= show size with best-matching unit) is preferred by most users.
I initially wanted to make this configurable, but for implementing
it in a non-hacky way extending KLocale from kdelibs would have
been required. I'm not sure whether the usecase in Dolphin justifies
having such a configuration in KLocale - however as kdelibs is frozen
at the moment this is no option and the old behavior has been
restored.
FIXED-IN: 4.9.0

M  +2    -5    dolphin/src/kitemviews/kfileitemlistwidget.cpp
M  +5    -25   dolphin/src/views/dolphinview.cpp
M  +0    -6    dolphin/src/views/dolphinview.h

http://commits.kde.org/kde-baseapps/99f4637da7cde6fb76816c43563700dceeb06e48
Comment 19 Peter Penz 2012-04-09 09:54:27 UTC
Git commit 5559aaaa0bf2f731ce2413f140b20f4a2d3c60b3 by Peter Penz.
Committed on 09/04/2012 at 11:53.
Pushed by ppenz into branch 'KDE/4.8'.

Revert the 2.0 decision to always use KB for file-sizes

The feedback on bugs.kde.org has shown that the previous behavior
(= show size with best-matching unit) is preferred by most users.
I initially wanted to make this configurable, but for implementing
it in a non-hacky way extending KLocale from kdelibs would have
been required. I'm not sure whether the usecase in Dolphin justifies
having such a configuration in KLocale - however as kdelibs is frozen
at the moment this is no option and the old behavior has been
restored.
FIXED-IN: 4.8.3

M  +2    -5    dolphin/src/kitemviews/kfileitemlistwidget.cpp
M  +5    -25   dolphin/src/views/dolphinview.cpp
M  +0    -6    dolphin/src/views/dolphinview.h

http://commits.kde.org/kde-baseapps/5559aaaa0bf2f731ce2413f140b20f4a2d3c60b3
Comment 20 Nikita Skovoroda 2012-04-09 10:00:07 UTC
Thanks!