Bug 289778 - [PATCH] oxygenstyle fails to build (final): missing #include <fixx11h.h>
Summary: [PATCH] oxygenstyle fails to build (final): missing #include <fixx11h.h>
Status: RESOLVED FIXED
Alias: None
Product: Oxygen
Classification: Plasma
Component: style (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-25 12:46 UTC by esigra
Modified: 2012-01-05 09:53 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
patch that fixes the build (397 bytes, patch)
2011-12-25 12:46 UTC, esigra 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description esigra 2011-12-25 12:46:23 UTC 
Created attachment 67095 [details]
patch that fixes the build

Version:           unspecified (using KDE 4.7.3) 
OS:                Linux

oxygenstyle fails to build with KDE4_ENABLE_FINAL=ON becasue a X11 header is included without the following #include <fixx11h.h>.

Reproducible: Always

Steps to Reproduce:
1. tar jxvf /usr/portage/distfiles/kde-workspace-4.7.3.tar.bz2
2. cd kde-workspace-4.7.3
3. mkdir build
4. cd build
5. cmake -DKDE4_ENABLE_FINAL=ON ..
6. make oxygenstyle

Actual Results:  
In file included from /usr/include/qt4/QtCore/QUrl:1:0,                                                                                                                                                     
                 from /usr/include/kurl.h:28,
                 from /usr/include/KDE/../conversion_check.h:32,
                 from /usr/include/KDE/../kconfiggroup.h:718,
                 from /usr/include/KDE/KConfigGroup:1,
                 from kde-workspace-4.7.3.orig/libs/oxygen/oxygenshadowconfiguration.h:32,
                 from kde-workspace-4.7.3.orig/libs/oxygen/oxygenshadowcache.h:30,
                 from kde-workspace-4.7.3.orig/libs/oxygen/oxygenshadowcache.cpp:27,
                 from kde-workspace-4.7.3.orig/build/libs/oxygen/oxygenstyle_final_cpp.cpp:5:
/usr/include/qt4/QtCore/qurl.h:70:9: fel: expected identifier before numeric constant
.
.
.

Expected Results:  
successful build
Comment 1 Hugo Pereira Da Costa 2012-01-05 09:50:06 UTC 
Git commit defc38b9e673cadc12315e32ef1583820a4a8bd8 by Hugo Pereira Da Costa.
Committed on 05/01/2012 at 10:48.
Pushed by hpereiradacosta into branch 'KDE/4.8'.

Added missing header

M  +1    -0    libs/oxygen/oxygenhelper.cpp

http://commits.kde.org/kde-workspace/defc38b9e673cadc12315e32ef1583820a4a8bd8
Comment 2 Hugo Pereira Da Costa 2012-01-05 09:50:07 UTC 
Git commit e4fce875f4cc2406f8ab53767b02301f8c9d385e by Hugo Pereira Da Costa.
Committed on 05/01/2012 at 10:48.
Pushed by hpereiradacosta into branch 'master'.

Added missing header

M  +1    -0    libs/oxygen/oxygenhelper.cpp

http://commits.kde.org/kde-workspace/e4fce875f4cc2406f8ab53767b02301f8c9d385e
Comment 3 Hugo Pereira Da Costa 2012-01-05 09:50:35 UTC 
Fixed ! 
Thanks for posting the patch and sorry for the delay.

Hugo