Bug 289528 - Date and time chooser doesn’t follow global KDE settings
Summary: Date and time chooser doesn’t follow global KDE settings
Status: RESOLVED FIXED
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: 1.3 (KDE 4.8)
Assignee: marble-bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-21 21:24 UTC by Karl Ove Hufthammer
Modified: 2012-05-20 11:26 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: KDE 4.9.0 / Marble 1.4.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Ove Hufthammer 2011-12-21 21:24:36 UTC
Version:           unspecified (using KDE 4.7.2) 
OS:                Linux

The date and time chooser doesn’t follow the KDE settings for displaying date and time. (Note that it *is* localisable, i.e., the translator for the user’s locale can change it, but it actually *shouldn’t* be; it should follow the user’s setting, like all other date and time displays in KDE.)

Here are the relevant strings and files to change:

"M/d/yyyy hh:mm"
#: src/plugins/render/earthquake/EarthquakeConfigWidget.ui:79
#: src/plugins/render/earthquake/EarthquakeConfigWidget.ui:103
#: src/plugins/render/opencaching/OpenCachingConfigWidget.ui:100
#: src/plugins/render/opencaching/OpenCachingConfigWidget.ui:114


"dd/MM/yyyy hh:mm AP"
src/lib/TimeControlWidget.ui:85
src/lib/TimeControlWidget.ui:119



Reproducible: Always

Steps to Reproduce:
Start Marble. Visit, for example, the time control dialogue.

Actual Results:  
Date and time uses "M/d/yyyy hh:mm" format (or a translation thereof), instead of the user’s global KDE settings.

Expected Results:  
Should have used global KDE settings.

OS: Linux (x86_64) release 3.1.0-1.2-desktop
Compiler: gcc
Comment 1 Dennis Nienhüser 2012-05-17 09:24:20 UTC
Git commit a0906be0ebb92e61226327af5406623a4495d24b by Dennis Nienhüser.
Committed on 17/05/2012 at 11:20.
Pushed by nienhueser into branch 'master'.

Don't override the default (locale) date/time display format

M  +0    -6    src/lib/TimeControlWidget.ui
M  +0    -6    src/plugins/render/earthquake/EarthquakeConfigWidget.ui
M  +0    -6    src/plugins/render/opencaching/OpenCachingConfigWidget.ui

http://commits.kde.org/marble/a0906be0ebb92e61226327af5406623a4495d24b
Comment 2 Dennis Nienhüser 2012-05-17 09:24:30 UTC
Can I backport such a change (it only removes strings) to KDE/4.8?