Created attachment 66865 [details] proposed patch Version: 1.4.0 (using Devel) OS: Linux Please see the attached patch: HTML Export: improve floating_cards theme - adds optional javascript-based keyboard navigation (left arrow = previous image, right arrow = next image) - adds optional preloading of next image The patch applies on top of my patch in Bug#149269, but the fuzz in the .desktop file is trivial to resolve, in case the other patch does not get accepted. Reproducible: Always Expected Results: .
Thanks Jiri. Your patch is processed against code from git/master i hope ? I would to include it to next 2.5.0 release. Look details here : http://digikam.org/drupal/contrib This remark is also valid for Bug #149269 Gilles Caulier
Created attachment 66884 [details] refreshed patch against current git umm, no, it was against 1.4.0 (lame, I know ... obviously, I have been looking at a rather outdated page http://www.kipi-plugins.org/drupal/node/5 ) This is a refreshed patch against current git - the only difference was some whitespace cleanup, fortunately. Compile-tested.
Created attachment 66885 [details] refreshed patch against current git eek - this is the correct refreshed patch (the previous one was for the other bug)
Created attachment 67206 [details] patch fixed to produce valid XHTML one more update: the original version of the patch produced invalid XHTML. I now reshuffled the newly added elements to pass XHTML validation.
Patch failed to be applied to git master : [gilles@localhost kipi-plugins]$ pwd /mnt/data/Devel/GIT/2.x/extra/kipi-plugins [gilles@localhost kipi-plugins]$ patch -p1 < floating_cards_add_keyboard_navigation_and_image_preloading.patch patching file htmlexport/themes/floating_cards/floating_cards.desktop Hunk #1 FAILED at 137. 1 out of 1 hunk FAILED -- saving rejects to file htmlexport/themes/floating_cards/floating_cards.desktop.rej patching file htmlexport/themes/floating_cards/image_nav.js patching file htmlexport/themes/floating_cards/style.css patching file htmlexport/themes/floating_cards/template.xsl Please make patch as it's described here : http://www.digikam.org/drupal/contrib Gilles Caulier
(In reply to comment #5) > [gilles@localhost kipi-plugins]$ patch -p1 < > floating_cards_add_keyboard_navigation_and_image_preloading.patch > > patching file htmlexport/themes/floating_cards/floating_cards.desktop > Hunk #1 FAILED at 137. > 1 out of 1 hunk FAILED -- saving rejects to file > htmlexport/themes/floating_cards/floating_cards.desktop.rej As I wrote in Comment #0, this patch applies on top of my patch in Bug #149269. If you decide not to accept the patch form Bug #149269, I'll attach a version of this patch that applies on top of current git.
Created attachment 67309 [details] patch that applies on top of current git, without patch from Bug 149269 (please consider applying patch from Bug #149269 first and using attachment #67206 [details] instead of this patch).
Git commit e68d3076748a362e595a66af0370256d9536d0ac by Gilles Caulier. Committed on 03/01/2012 at 15:45. Pushed by cgilles into branch 'master'. apply patch #67206 from Jiri Bohac M +30 -0 htmlexport/themes/floating_cards/floating_cards.desktop M +4 -0 htmlexport/themes/floating_cards/style.css M +10 -4 htmlexport/themes/floating_cards/template.xsl http://commits.kde.org/kipi-plugins/e68d3076748a362e595a66af0370256d9536d0ac