Bug 288941 - Can't scroll to the top of a conversation
Summary: Can't scroll to the top of a conversation
Alias: None
Product: telepathy
Classification: Frameworks and Libraries
Component: text-ui (show other bugs)
Version: git-latest
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: 0.4.0
Assignee: Telepathy Bugs
Depends on:
Blocks: 285413
  Show dependency treegraph
Reported: 2011-12-14 07:44 UTC by Elias Probst
Modified: 2012-07-06 12:47 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:

Screenshot of Renkoo preview. (71.00 KB, image/png)
2011-12-14 07:44 UTC, Elias Probst
Side effect of the first solution (45.09 KB, image/png)
2011-12-15 11:13 UTC, Dominik Cermak
Side effect of the second solution (39.56 KB, image/png)
2011-12-15 11:14 UTC, Dominik Cermak

Note You need to log in before you can comment on or make changes to this bug.
Description Elias Probst 2011-12-14 07:44:08 UTC
Created attachment 66725 [details]
Screenshot of Renkoo preview.

Version:           git-latest (using Devel) 
OS:                Linux

When using the Renkoo theme for Text-UI, the conversion can't be scrolled to the top.
The first 2 lines are always covered by the header element of the theme.

Reproducible: Always

Steps to Reproduce:
1. Configure Text-UI to use the Renkoo theme
2. Make a long conversation
3. Scroll to the top

Actual Results:  
The first 2 lines aren't visible, as they're hidden behind the header element of the theme.

Expected Results:  
I'd expect to be able to see all text when scrolling to the top.

See the attached screenshot, which demonstrates the problem in the preview of the theme configuration dialog.
Comment 1 Dominik Cermak 2011-12-15 10:56:22 UTC
Seems like the theme is broken. Renkoo from http://www.adiumxtras.com/ ships with an own Template.html and doesn't have this Problem, but it adds the messages from the top and not from the bottom, like the Renkoo from text-ui does.
Comment 2 Dominik Cermak 2011-12-15 11:13:51 UTC
Created attachment 66774 [details]
Side effect of the first solution

Looking at another theme (GoneDark), there are two possible solutions if we want to keep the behavior of adding messages at the bottom of the chat-area.
Both have a side effect.

The first one adds a scroll-bar after the first message.
The second one adds a clear area with the size of the header on top if you have disabled the header.
Comment 3 Dominik Cermak 2011-12-15 11:14:23 UTC
Created attachment 66775 [details]
Side effect of the second solution
Comment 4 David Edmundson 2011-12-15 11:30:08 UTC
"Renkoo from http://www.adiumxtras.com/ ships with an own Template.html and doesn't have this Problem"

I believe (though could be wrong) when Renkoo became the default theme for Adium it moved into the Adium source tree, and is more up to date there. It's that version we are using in our code.

Would be interesting to see what Adium itself does.

I used to have a rule that we don't alter the themes themselves (as it implies  we're doing something "wrong" in the processing) and we should be fixing that not the visible issue, however given I want to replace the whole thing eventually (this Adium theme stuff sucks heavily) I no longer mind.

What happens when you combine the second solution with https://git.reviewboard.kde.org/r/102005/diff/#index_header ?
Comment 5 Dario Freddi 2011-12-21 17:55:30 UTC
Dominik Cermak fixed this bug with commit gc20a4db

(P.S.: If any of the admins is listening, please give karma to this good guy)