Bug 288722 - Motion blur filter shows weird white stripes.
Summary: Motion blur filter shows weird white stripes.
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Filters (show other bugs)
Version: git master (please specify the git hash!)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-11 14:07 UTC by animtim
Modified: 2013-12-01 18:05 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description animtim 2011-12-11 14:07:02 UTC
Version:           svn trunk (using KDE 4.5.5) 
OS:                Linux

In 16/32 bits float files, most filters don't work as expected or even at all, with or without crash… here is a quicklist:

-All adjust filters don't work (they produce a solid color, black or orange or red… depending on the filters, no matter what the filters settings are)

-Artistic: Pixelize works, Raindrops works though a bit long to render, Oilpaint crash when I select it.

-Blurs: Gaussian preview work, but produces a black strip on the right border when applied. Almost the same for motion blur, but produces a small white strip at the same right border. Simple Blur works ok. Lens blur looks ok with default settings, but big tiles artefacts appear when increasing radius.

-Colors: Color to Alpha erase all, the others I'm not sure what they're supposed to do but they don't seem to work correctly.

Same thing for many of the rest I don't know much of what these should do, but some results really looks wrong here.

All filters in "Other" category are crashing Krita (actually I didn't tested all, but all that I tested there did crash directly…)

Reproducible: Always

Steps to Reproduce:
See details description

Actual Results:  
See details description

Expected Results:  
See details description
Comment 1 Halla Rempt 2011-12-18 13:33:58 UTC
Ack
Comment 2 Cyrille Berger 2012-01-12 20:40:23 UTC
This is a bug with llvm 2.8 and sandy bridge. Fixed by upgrading llvm.
Comment 3 Cyrille Berger 2012-01-12 20:44:11 UTC
wrong bug report... but I can't reproduce the crashes though. So it might still be the llvm 2.8 and sandy bridge stuff... What is your version of llvm ?
Comment 4 Cyrille Berger 2012-01-14 07:31:34 UTC
I just tried:

* adjustment filter: I did not had any problem, the only thing is that they lose the dynamic range, but they do warn about it
* the artistic filters behaves poorly on other color spaces as well. Especially with respect to performance. I did not have any crash with the oilpaint one though (might be because of the patch to prevent multithreading)
* I get a strip in motion blur with all colorspaces, I did not see the artefact for gaussian blur, it might be interesting to know which parameters you are using. Lens blur artefacts also appears with other color spaces.
* color to alpha worked for me, minimize/maximize are working properly (I guess the fact they give ugly results is what is surprising ;P, and I would question their usefulness for artistic purposes), color transfert works to the extent that it does not like to not work on the full image
* the others are broken with all colorspaces as well
Comment 5 animtim 2012-01-15 14:10:47 UTC
Ok so now that it requires newer openGTL I can't test it anymore;
I've tried to build openGTL from mercurial, but it needs llvm 3.0, and mine
is 2.8 indeed…

As I don't really need those features (yet!) I'll wait for newer llvm and
opengtl in the repository (probably in a future *buntu versions :P )
Comment 6 Halla Rempt 2012-08-28 14:19:52 UTC
Interesting... Most of these filters now work, but this is still true:

"-Blurs: Gaussian preview work, but produces a black strip on the right border when applied. Almost the same for motion blur, but produces a small white strip at the same right border."
I suspect someone is counting bytes instead of pixels somewhere here!
Comment 7 Halla Rempt 2013-09-25 14:55:48 UTC
Motion blur is broken at any channel depth.
Comment 8 Cyrille Berger 2013-12-01 18:05:15 UTC
Git commit 7db029a1f8902873b5c6a76c2d72941290807c6a by Cyrille Berger.
Committed on 01/12/2013 at 15:48.
Pushed by berger into branch 'master'.

remove shiva plugin and dependency on opengtl stuff

CCMAIL:kimageshop@kde.org

closing related bugs as no more valids:
Related: bug 289776, bug 323364, bug 289191

D  +0    -20   cmake/modules/FindOpenCTL.cmake
D  +0    -19   cmake/modules/FindOpenShiva.cmake
D  +0    -19   cmake/modules/FindQtShiva.cmake
M  +0    -20   krita/CMakeLists.txt
M  +0    -10   krita/plugins/extensions/CMakeLists.txt
D  +0    -44   krita/plugins/extensions/shiva/CMakeLists.txt
D  +0    -176  krita/plugins/extensions/shiva/PaintDeviceImage.cpp
D  +0    -58   krita/plugins/extensions/shiva/PaintDeviceImage.h
D  +0    -111  krita/plugins/extensions/shiva/QVariantValue.cpp
D  +0    -28   krita/plugins/extensions/shiva/QVariantValue.h
D  +0    -65   krita/plugins/extensions/shiva/ShivaGeneratorConfigWidget.cpp
D  +0    -42   krita/plugins/extensions/shiva/ShivaGeneratorConfigWidget.h
D  +0    -38   krita/plugins/extensions/shiva/UpdaterProgressReport.cpp
D  +0    -37   krita/plugins/extensions/shiva/UpdaterProgressReport.h
D  +0    -4    krita/plugins/extensions/shiva/collections/CMakeLists.txt
D  +0    -33   krita/plugins/extensions/shiva/collections/filters/AntiBullify.shiva
D  +0    -34   krita/plugins/extensions/shiva/collections/filters/Bullify.shiva
D  +0    -2    krita/plugins/extensions/shiva/collections/filters/CMakeLists.txt
D  +0    -48   krita/plugins/extensions/shiva/collections/filters/Caleidoscope.shiva
D  +0    -30   krita/plugins/extensions/shiva/collections/filters/CentralAbsorbtion.shiva
D  +0    -22   krita/plugins/extensions/shiva/collections/filters/Contraction.shiva
D  +0    -463  krita/plugins/extensions/shiva/collections/filters/Droste.shiva
D  +0    -30   krita/plugins/extensions/shiva/collections/filters/Expansion.shiva
D  +0    -73   krita/plugins/extensions/shiva/collections/filters/Hypno.shiva
D  +0    -58   krita/plugins/extensions/shiva/collections/filters/LensCorrection.shiva
D  +0    -23   krita/plugins/extensions/shiva/collections/filters/MirrorImpose.shiva
D  +0    -27   krita/plugins/extensions/shiva/collections/filters/Mosaic.shiva
D  +0    -70   krita/plugins/extensions/shiva/collections/filters/Planes.shiva
D  +0    -70   krita/plugins/extensions/shiva/collections/filters/Ray.shiva
D  +0    -70   krita/plugins/extensions/shiva/collections/filters/Ray2.shiva
D  +0    -35   krita/plugins/extensions/shiva/collections/filters/Ripples.shiva
D  +0    -44   krita/plugins/extensions/shiva/collections/filters/RotativeBlur.shiva
D  +0    -47   krita/plugins/extensions/shiva/collections/filters/Roundify.shiva
D  +0    -45   krita/plugins/extensions/shiva/collections/filters/Sea.shiva
D  +0    -51   krita/plugins/extensions/shiva/collections/filters/Seamlesser.shiva
D  +0    -48   krita/plugins/extensions/shiva/collections/filters/Sectorize.shiva
D  +0    -34   krita/plugins/extensions/shiva/collections/filters/Slices.shiva
D  +0    -70   krita/plugins/extensions/shiva/collections/filters/Sphere.shiva
D  +0    -70   krita/plugins/extensions/shiva/collections/filters/Star.shiva
D  +0    -115  krita/plugins/extensions/shiva/collections/filters/StereographicProjection.shiva
D  +0    -70   krita/plugins/extensions/shiva/collections/filters/Tunnel.shiva
D  +0    -69   krita/plugins/extensions/shiva/collections/filters/Tunnel2.shiva
D  +0    -43   krita/plugins/extensions/shiva/collections/filters/ZigZag.shiva
D  +0    -40   krita/plugins/extensions/shiva/collections/filters/oilify.shiva
D  +0    -2    krita/plugins/extensions/shiva/collections/generators/CMakeLists.txt
D  +0    -47   krita/plugins/extensions/shiva/collections/generators/CheckerBoard.shiva
D  +0    -54   krita/plugins/extensions/shiva/collections/generators/ConcentricCircles.shiva
D  +0    -68   krita/plugins/extensions/shiva/collections/generators/Disco.shiva
D  +0    -809  krita/plugins/extensions/shiva/collections/generators/FractalExplorer.shiva
D  +0    -80   krita/plugins/extensions/shiva/collections/generators/Metaball.shiva
D  +0    -42   krita/plugins/extensions/shiva/collections/generators/Moire.shiva
D  +0    -113  krita/plugins/extensions/shiva/collections/generators/PerlinNoise.shiva
D  +0    -76   krita/plugins/extensions/shiva/collections/generators/Plasma.shiva
D  +0    -29   krita/plugins/extensions/shiva/collections/generators/RadialGradient.shiva
D  +0    -63   krita/plugins/extensions/shiva/collections/generators/Singleball.shiva
D  +0    -80   krita/plugins/extensions/shiva/collections/generators/Something.shiva
D  +0    -56   krita/plugins/extensions/shiva/collections/generators/SunRay.shiva
D  +0    -92   krita/plugins/extensions/shiva/collections/generators/SuperNova.shiva
D  +0    -63   krita/plugins/extensions/shiva/kritashivafilters.desktop
D  +0    -63   krita/plugins/extensions/shiva/kritashivagenerators.desktop
D  +0    -111  krita/plugins/extensions/shiva/shivafilter.cpp
D  +0    -45   krita/plugins/extensions/shiva/shivafilter.h
D  +0    -69   krita/plugins/extensions/shiva/shivafiltersplugin.cpp
D  +0    -41   krita/plugins/extensions/shiva/shivafiltersplugin.h
D  +0    -108  krita/plugins/extensions/shiva/shivagenerator.cpp
D  +0    -49   krita/plugins/extensions/shiva/shivagenerator.h
D  +0    -70   krita/plugins/extensions/shiva/shivageneratorsplugin.cpp
D  +0    -40   krita/plugins/extensions/shiva/shivageneratorsplugin.h

http://commits.kde.org/calligra/7db029a1f8902873b5c6a76c2d72941290807c6a