Bug 288611 - manual-update and manual-build do not work for KDE project module-sets.
Summary: manual-update and manual-build do not work for KDE project module-sets.
Status: RESOLVED FIXED
Alias: None
Product: kdesrc-build
Classification: Developer tools
Component: general (show other bugs)
Version: Git
Platform: Debian unstable Linux
: NOR normal
Target Milestone: ---
Assignee: Michael Pyne
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-09 23:22 UTC by Michael Pyne
Modified: 2017-10-07 20:19 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.15


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Pyne 2011-12-09 23:22:00 UTC
As reported in bug 288378, the manual-update and manual-build options do not work when set for modules that are submodules of a KDE Project module set. (Note: Unconfirmed by myself at this point).
Comment 1 Michael Pyne 2012-01-13 02:39:05 UTC
Hmm, seems at some point duplicate module option consolidation got removed. I'll be re-adding this as it is a very useful feature to have when reading options for module sets.
Comment 2 Michael Pyne 2012-01-15 22:27:24 UTC
Git commit 2f29db0ed9c5692513838941091ae226c12bdbfc by Michael Pyne.
Committed on 14/01/2012 at 04:20.
Pushed by mpyne into branch 'master'.

Ensure module options override module-set options for same module.

It has always been the intention since module-set was introduced that it
would be possible to override options set for a module used in that
module-set by making a later module declaration, without that later
module declaration actually changing the build order or making any other
effect. This feature was broken and reported as a bug.

I've added a testcase to reproduce the problem, and I have fixed it by
passing back to parse_module() existing Module objects when present, and
modified parse_module() to not create new Module objects in that case
but to modify the one provided.

I've also added a warning for modules that do not appear to be part of a
module set as this indicates duplicate modules passed in the config
file. As of right now the way this test works is to look for a
module-set name but those are optional, so what I'll probably do is
auto-generate a module-set name based on the line number. That will come
later though.
FIXED-IN:1.15

M  +42   -8    kdesrc-build
M  +7    -0    kdesrc-build-test.pl

http://commits.kde.org/kdesrc-build/2f29db0ed9c5692513838941091ae226c12bdbfc