Bug 287565 - Korganizer crashes every time at any attempt to set a timezone other than UTC for an event or a to-do, or to edit an imported event/to-do with such timezone
Summary: Korganizer crashes every time at any attempt to set a timezone other than UTC...
Status: RESOLVED UNMAINTAINED
Alias: None
Product: korganizer
Classification: Applications
Component: timezones (show other bugs)
Version: 4.8.x
Platform: Microsoft Windows Microsoft Windows
: NOR crash
Target Milestone: ---
Assignee: KDE-Windows
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-25 17:36 UTC by Maksym Kozub
Modified: 2017-01-07 21:56 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maksym Kozub 2011-11-25 17:36:33 UTC
Version:           4.7 (using KDE 4.7.0) 
OS:                MS Windows

The summary basically says it all :). There are two types of situations, and both seem to be caused by the same bug (somewhere in libical or maybe elsewhere). See below the steps to reproduce the bug.

Reproducible: Always

Steps to Reproduce:
Method 1.
Start Korganizer with an empty calendar, create an event or a to-do with start time or end time (by unchecking "Takes the whole day"), click on "Time zones", select anything (other than UTC or initial "Floating") from the drop-down list. Korganizer crashes.

Method 2.
Start Korganizer with an empty calendar, import (either as a separate calendar, or merging into the empty main one, it doesn't matter) an .ics file made by Lightning or Sunbird with events or to-dos having timezones like Europe/Kiev or America/New York.

Actual Results:  
Korganizer crashes.

Expected Results:  
The timezone for start time or end time for the event or to-do being created or edited is set to the one selected from te drop-down list.

It happens in 4.7.0 downloaded and installed from windows.kde.org (in both MinGW4 and MSVC versions), as well as in Kolab client from kolab.org (already uninstalled it, but as far as I remember it is based on 4.7.1).

The OS is Windows 7 Starter.

It is a pity to see this bug, because I do like Korganizer/KDE PIM features and UI more than those of Lightning or any other calendar software I tried, but I cannot use it at the moment. Being an interpreter and translator, I travel quite a lot as an interpreter, and generally have to deal with various timezones, so this inability to properly handle them is a real (and the only) showstopper for me...

It may be related to https://bugs.kde.org/show_bug.cgi?id=68345.
Comment 1 Maksym Kozub 2011-11-25 18:05:19 UTC
In method 2 above, the last sentence is missing, which is "Try to open such event or to-do for editing".
Comment 2 Bogdan Udrescu 2011-11-26 22:32:27 UTC
I tried both of your methods using KDE 4.7.2. I did not encounter any problem so I think this was fixed. Please upgrade and post feedback. So far I consider this fixed or and isolated issue.
Comment 3 Maksym Kozub 2011-11-27 08:02:02 UTC
(In reply to comment #2)

> I tried both of your methods using KDE 4.7.2.

Then please tell me where to obtain Windows binaries of ver. 4.7.2.

> Please upgrade and post feedback.

Please see the above question. The only Windows binary distributions that I have found are (1) KDE Software Compilation 4.7.0 (whhich has KDE PIM version indicated as 4.7.0-1) from kde.org, and (2) Kolab5, which is 4.7.1 if my memory serves me well.
Or do you mean "Compile 4.7.2 from sources"? The last time I compiled software from sources was almost 20 years ago, and I do not have the required time, skills, etc. to do it now. 

> So far I consider this fixed or and isolated issue.

So far I still consider this to be an issue in _the latest version of WIndows distribution_ of KDE. If you have actually found or compiled ver. 4.7.2 binaries for WIndows, then I will say "OK, I will wait until those become generally availablem and I will try them then". However, until you clarify the situation with KDE 4.7.2 for Windows, I do not see any reasons to consider this specific issue fixed.
Comment 4 Myriam Schweingruber 2011-11-30 13:06:48 UTC
I think Bogdan didn't see this was about Windows, sorry for the noise. There is indeed no binary release for a newer version than KDE 4.7.2 yet.
Comment 5 Maksym Kozub 2011-11-30 13:34:50 UTC
(In reply to comment #4)
> There is indeed no binary release for a newer version than KDE 4.7.2 yet.

You probably mean "Newer than KDE 4.7._1_", because Kolab5 is I think 4.7.1, and 4.7.2 binaries for Windows do not seem to have been published by anybody yet...
Comment 6 Andre Heinecke 2012-01-30 09:48:30 UTC
This is indeed an ugly bug sorry for not reacting earlier but i've overlooked this report so far.

I've updated the Kolab client package to KDE 4.8rc2 but the bug still is in there. Just tried it. (I actually always used "floating" for my Appointments and never noticed this problem before)

I also crash when i try to add a second timezone to the agendaview. This is a regression, with the 4.6 build I was able to do this.

I'm reassining this to kde-windows as this is Windows specific.
Comment 7 Andre Heinecke 2012-02-06 18:04:03 UTC
Windbg shows the following information for that crash (thanks to patrick spendrin for getting this with debug symbols):

KERNELBASE!TimeZoneInformationCompare+0x10
KERNELBASE!TzSpecificLocalTimeToSystemTime+0x64
kdecore!TzSpecificLocalTimeToSystemTime_Portable+0xd7
kdecore!offset_at_zone_time+0x62
kdecore!KSystemTimeZoneBackendWindows::offsetAtZoneTime+0x82
kdecore!KTimeZone::offsetAtZoneTime+0x18
kdecore!KDateTimePrivate::timeZoneOffset+0xea
kdecore!KDateTimePrivate::toUtc+0x220
kdecore!KDateTime::operator==+0x2f8
WARNING: Stack unwind information not available. Following frames may be wrong.
incidenceeditorsng!IncidenceEditorNG::IncidenceAlarm::updateButtons+0x415fc
incidenceeditorsng!IncidenceEditorNG::IncidenceAlarm::updateButtons+0x43078
Comment 8 Andre Heinecke 2012-02-21 11:42:42 UTC
To document some more infomration on this.
I did a bit debugging into this and the problem is that since revision ( http://quickgit.kde.org/index.php?p=kdelibs.git&a=commit&h=1eeaa054de00b753945c4f2c16c6324a61abbe19 ) in kdelibs a combination of olson names and windows timzone names is mixed. This causes the lookup for some timzones to fail which don't have a correct Windows equivalent defined. So the data structure for the timezones can not be initialized and it crashes.

This happens for a lot of timezones, but the fix is not so easy as to just add the missing timezones to the olson/windows mapping. This will fix the crash and the timezones are then initialized but the calculation is wrong.
Just reverting the beforementioned commit also causes wrong results.

Since the timzone names are also localized on Windows the code we have in also appears to be only working on English systems.

So the "fix" for this crash is easy,.. but it only exposed a larger problem that timezones are currently not handled correctly on Windows. The Unittests also fail wrt. to actual calculations.
Comment 9 Maksym Kozub 2012-04-13 18:43:40 UTC
Still the same behaviour in 4.8.0.
Comment 10 Ingo Ratsdorf 2012-06-04 21:28:41 UTC
The actual crash seem to have been fixed.
I am using 4.8.0 on windows and any new incidence that I add to KOrganizer will be offset by 12 hrs.
Example: I create an event for 8:00 to 9:00 in Pacific/Auckland and the event will be shown in agenda view as 20:00 to 21:00. Editing the event however still shows the cirrect time 8:00 to 9:00.
Please note that the KOrganizer main window does not show the Olsen TZ of "Pacific/Auckland" but "New Zealand Standard Time". I cannot change that anywhere in the KDE system nor in KOrganizer.
However, all events imported via CalDAV are shown correct. Until I edit any of them. Then shey will be offset by 12 hrs as well.
Comment 11 Maksym Kozub 2012-07-02 22:17:53 UTC
(In reply to comment #10)
> The actual crash seem to have been fixed.

Here it does not seem so.

> I am using 4.8.0 on windows

Same here.

> Example: I create an event for 8:00 to 9:00 in Pacific/Auckland and the
> event will be shown in agenda view as 20:00 to 21:00. Editing the event
> however still shows the cirrect time 8:00 to 9:00.

Here any attempt to create an event in Pacific/Auckland TZ still results in a crash.
Comment 12 Maksym Kozub 2012-07-02 22:20:23 UTC
(In reply to comment #8)

> So the "fix" for this crash is easy,.. but it only exposed a larger problem
> that timezones are currently not handled correctly on Windows. The Unittests
> also fail wrt. to actual calculations.

Any news about this problem (i.e. handling of timezones on Windows)?..
Comment 13 Ingo Ratsdorf 2013-05-20 03:13:53 UTC
Using windows binaries 4.10.2 (32bit)

The crash issue has gone away, however the timezone "Pacific/Auckland" is apparently not known to KDE.
Creating a new event, it will be set to "New Zealand Standard Time" .
And the event will automatically move to UTC. Ie creating an event for 16:00 will move it to 4:00 the next day. Seems that KDE cannot handle its own TZ proposal.
The CalDAV server automatically changes it to the right time, ie "Pacific/Auckland", but since the etag is not modified, KDE does not pick up that change.
Upon modification by another use, the event etag on the server is updated and reloaded by KDE and appear correctly in KOrganizer for the original 16:00 time.

So KDE still cannot handle timezones fully, however at least KOrganizer does not crash any more... ;-)
Comment 14 Ingo Ratsdorf 2013-06-14 03:35:23 UTC
No crash any more but still the inability of the Akonadi System to recognise timezones. Whatever event I am creating, it will move to UTC, despite showing the right timezone in the RAW payload in Akonadiconsole. But somehow that timezone cannot be interpreted correctly into a correct payload, at least not for "Pacific/Auckland" nor for "New Zealand Standard Time".
Comment 15 Denis Kurz 2016-09-24 18:46:34 UTC
This bug has only been reported for versions before 4.14, which have been unsupported for at least two years now. Can anyone tell if this bug still present?

If noone confirms this bug for a Framework-based version of korganizer (version 5.0 or later, as part of KDE Applications 15.08 or later), it gets closed in about three months.
Comment 16 Denis Kurz 2017-01-07 21:56:14 UTC
Just as announced in my last comment, I close this bug. If you encounter it again in a recent version (at least 5.0 aka 15.08), please open a new one unless it already exists. Thank you for all your input.