Bug 287309 - KTorrent plasma applet fails to build with recent kde-workspace/master
Summary: KTorrent plasma applet fails to build with recent kde-workspace/master
Status: RESOLVED FIXED
Alias: None
Product: ktorrent
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Joris Guisson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-22 21:35 UTC by Christoph Feck
Modified: 2011-11-23 19:17 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Feck 2011-11-22 21:35:31 UTC 
The taskmanager API in kde-workspace got some cleanup (see commits today). Part of the cleanup involved removing the TaskDict typedef, and replacing it with a QHash<> type.

KTorrent uses TaskDict to iterate the running tasks (see ktorrent/plasma/applet/applet.cpp:344) and therefor the build fails.

This should either be adapted to the API change, or (better) be replaced with a D-Bus method to check for the already running application and activate it. It is probably simplest to check how KUniqueApplication does it.
Comment 1 Christoph Feck 2011-11-22 21:47:47 UTC 
According to plasma developers, libtaskmanager API should not be used outside of kde-workspace and kdeplasma-addons.
Comment 2 Joris Guisson 2011-11-23 19:17:28 UTC 
Git commit 6d4a6ae51692966862ccb20d17cb217717519d40 by Joris Guisson.
Committed on 23/11/2011 at 20:17.
Pushed by guisson into branch 'master'.

Use dbus to show ktorrent window from plasma applet. This removes the dependency on libtaskmanager.

BUG: 287309

M  +1    -0    ChangeLog
M  +10   -20   plasma/applet/CMakeLists.txt
M  +40   -16   plasma/applet/applet.cpp
M  +2    -0    plasma/applet/applet.h

http://commits.kde.org/ktorrent/6d4a6ae51692966862ccb20d17cb217717519d40