Bug 287212 - kcontrol installs keyboard test files in wrong location
Summary: kcontrol installs keyboard test files in wrong location
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_keyboard (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR minor
Target Milestone: ---
Assignee: Andriy Rysin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-22 00:03 UTC by Andrea Scarpino
Modified: 2011-11-22 01:53 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Andrea Scarpino 2011-11-22 00:03:54 UTC 
Version:           unspecified (using Devel) 
OS:                Linux

I built the latest kde-workspace from git and it installed these files in a wrong location.

$ ls /build/src/build/kcontrol/keyboard/tests/config/
base.1.1.xml  base.bad.xml  base.xml

I built it in a chroot, and /build/src/build is the dir in which I build kde-workspace.

My cmake options are:
        cmake ../kde-workspace \
        -DCMAKE_BUILD_TYPE=Release \
        -DCMAKE_SKIP_RPATH=ON \
        -DCMAKE_INSTALL_PREFIX=/usr \
        -DWITH_Xmms=OFF \
        -DWITH_Googlegadgets=OFF \
        -DWITH_libgps=OFF \
        -DWITH_OpenGLES=ON \
        -DKWIN_BUILD_WITH_OPENGLES=ON


Reproducible: Always

Steps to Reproduce:
build the kde-workspace from git

Actual Results:  
Everything works but those files are installed in a wrong location.

Expected Results:  
Files are installed in the right location.

KDE from git
Comment 1 Nicolas L. 2011-11-22 01:28:06 UTC 
this is because there is an error in kcontrol/keyboard/tests/CMakeLists.txt

install( DIRECTORY config DESTINATION ${CMAKE_CURRENT_BINARY_DIR} )

what should be the good behaviour ? not to install test ? or if we need to install, where should it be ?
Comment 2 Christophe Marin 2011-11-22 01:53:24 UTC 
Git commit ecb88c2d999b5a69eda67b72b8e2a74cb56ee331 by Christophe Giboudeaux.
Committed on 22/11/2011 at 02:53.
Pushed by cgiboudeaux into branch 'master'.

Don't install files in the build dir.
BUG: 287212

M  +3    -1    kcontrol/keyboard/tests/CMakeLists.txt

http://commits.kde.org/kde-workspace/ecb88c2d999b5a69eda67b72b8e2a74cb56ee331