Bug 287081 - F2 renames image, not Album in Thumbnails mode
Summary: F2 renames image, not Album in Thumbnails mode
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-IconView (show other bugs)
Version: 2.4.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-20 16:34 UTC by Frederic Grelot
Modified: 2017-08-04 21:05 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.1.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Grelot 2011-11-20 16:34:23 UTC
Version:           2.4.0 (using KDE 4.7.3) 
OS:                Linux

When I select an album and hit F2 to rename it, the popup proposes to rename the selected image, not the album.

Reproducible: Always

Steps to Reproduce:
Select an album in the album tree. An image is automatically selected in the right pane. A dotted rectangle surrounds the album name, not the image, showing that the focus is on the album tree pane. Now hit F2 to rename that album

Actual Results:  
the popup proposes to rename the image from the right pane

Expected Results:  
the popup should be the same as when I use right click/rename album.

OS: Linux (x86_64) release 3.1.1-1.fc16.x86_64
Compiler: gcc
Comment 1 Marcel Wiesweg 2012-02-21 17:26:06 UTC
Such a solution is available with two QActions of limited shortcut context for the left sidebar and for the remaining widgets.
Now unfortunately, it seems that the KDE gui framework cannot work with that; when adding such an action, the infamous "ambiguous shortcut" popup comes up, although the shortcut context is clearly defined.

That means
a) we cannot implement this within the KDE framwork
b) we could implement it with QAction only, hardcoding the F2 shortcut without the possibility to customize it
Comment 2 caulier.gilles 2014-08-31 22:11:38 UTC

*** This bug has been marked as a duplicate of bug 327628 ***
Comment 3 DrSlony 2014-09-01 06:08:24 UTC
It would be a significant time saver to be able to rename albums using a keyboard shortcut. If you need to hard-code it, i suggest Ctrl+r or Shift+F2.
Comment 4 caulier.gilles 2014-09-01 07:00:27 UTC
Git commit e73950979ebef04aec2c22a75d36def2bfd6c2f7 by Gilles Caulier.
Committed on 01/09/2014 at 06:59.
Pushed by cgilles into branch 'master'.

add SHIFT+F2 keyboard shortcut to rename album.
plug this action in main Album menu
Related: bug 327628
FIXED-IN: 4.3.0

M  +3    -2    NEWS
M  +15   -4    digikam/main/digikamapp.cpp
M  +2    -0    digikam/main/digikamapp_p.h
M  +2    -1    digikam/main/digikamui.rc
M  +2    -2    digikam/utils/contextmenuhelper.cpp
M  +5    -0    digikam/views/digikamview.cpp
M  +1    -0    digikam/views/digikamview.h

http://commits.kde.org/digikam/e73950979ebef04aec2c22a75d36def2bfd6c2f7
Comment 5 Frederic Grelot 2016-08-03 16:11:20 UTC
I would like to reopen this bug, for two reasons :

-Marcel (in comment #1) said that there is no such possibility in KDE framework to affect a shortcut without any ambiguity. However, I can't believe that point, since in every file manager I know, if the "tree" view has the focus and I hit F2, the folder get renamed, while if the "file" view has it, the currently selected file is renamed. Am I missing something?
-In the current situation, is it possible to add an hint in the right-click popup to tell that "Shift+F2" renames the folder?

Actually, I came back to this bug for the second point, because it seems like I hit it again... I hit "F2" as usual, and was asked to rename a picture. So I remembered "my" bug, searched for it, and saw in comment #4 that "Shift+F2" would do the trick : not really straightforward :-)
Comment 6 Maik Qualmann 2016-08-03 17:19:39 UTC
Git commit d7f536a4030b664e99210ab696b4d3f4752ee220 by Maik Qualmann.
Committed on 03/08/2016 at 17:18.
Pushed by mqualmann into branch 'master'.

add shortcuts to context menu

M  +1    -0    app/utils/contextmenuhelper.cpp

http://commits.kde.org/digikam/d7f536a4030b664e99210ab696b4d3f4752ee220