Version: 2.4.3 (using KDE 4.6.5)
When the new setting "Use composer instead of performer for scrobbling" is on, amaroK should still scrobble performer when composer tag is empty or absent.
But that doesn't happen, amarok happily scrobbles empty composer, liblastfm turns it into [unknown] and last.fm dropps the scrobble on the floor.
Annoying bug - if you checked the option accidentally, scrobbling would be silently not working and troubleshooting isn't easy.
Steps to Reproduce:
Turn on the checkbox.
Listen to some track.
last.fm wouldn't show that you listen to anything
The post body would be like
This is really a corner case. I listen to classical music a lot, but don't use the composer scrobbling, as it usually doesn't give coherent results in last.fm, their datsbase is not really made for classical music.
The problem is clicking the option accidentallly. You'll spend a week never knowing what hit you.
Created attachment 66122 [details]
This patch fixes the issue and also refactors a bit
This patch fixes the issue by checking whether the composer is empty and falling back to performer.
I've also refactored out repetitive track-populating code into a method.
Thank you for the patch. Please submit it for review to http://reviewboard.kde.org. You will need to get an identity from http://identity.kde.org first.
Git commit f9feaf51acfca9eb9994123ffb1929c65d99aa23 by Sam Lade.
Committed on 28/11/2011 at 03:40.
Pushed by lade into branch 'master'.
Fix last.fm scrobble composer fallback to artist
Now correctly scrobbles with the artist name if the composer field is empty and
the scrobble composer option is enabled, rather than silently failing.
Patch by Ilya Kasnacheev.
M +1 -0 ChangeLog
M +27 -25 src/services/lastfm/ScrobblerAdapter.cpp
M +2 -1 src/services/lastfm/ScrobblerAdapter.h