Bug 285382 - No color management/visual rendering when loading a picture with an embedded color profile.
Summary: No color management/visual rendering when loading a picture with an embedded ...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Color models (show other bugs)
Version: git master (please specify the git hash!)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Halla Rempt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-31 10:56 UTC by Ico_dY
Modified: 2011-10-31 23:36 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Selected options in Gimp for color management. (82.22 KB, image/jpeg)
2011-10-31 10:56 UTC, Ico_dY
Details
My monitor's color profile. (18.09 KB, application/vnd.iccprofile)
2011-10-31 10:57 UTC, Ico_dY
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ico_dY 2011-10-31 10:56:44 UTC
Created attachment 65064 [details]
Selected options in Gimp for color management.

Version:           svn trunk
OS:                Linux

I've calibrated and profiled my monitor with an hardware colorimeter piloted by dispcalgui & argyll.
My monitor profile (you can download it from here for inspection: http://www.mediafire.com/file/2g1dv06qz4jcqpq/eizo.icc ) is installed on my system through dispwin and recognized by other color managed applications (Gimp, Geequie, etc. etc. ) making correct color space conversion and visual rendering. As image color space I've always selected IEC61966-2.1 sRGB.

No color management/visual rendering in Krita when loading a picture with an embedded color profile.

Reproducible: Always

Steps to Reproduce:
Load any file with an embedded color profile.

Actual Results:  
No Color Management/Visual Rendering.

Expected Results:  
Krita should show a color managed picture with the same visual rendering as Gimp and other color managed applications.

I've installed my monitor's color profile with:
dispwin -I eizo.icc

And if I verify his loading with:
dispwin -V eizo.icc

It answers me with:
Verify: 'eizo.icc' IS loaded (discrepancy 0.0%)

So the monitor profile is correctly installed...
Comment 1 Ico_dY 2011-10-31 10:57:51 UTC
Created attachment 65065 [details]
My monitor's color profile.
Comment 2 Ico_dY 2011-10-31 11:51:22 UTC
I've compiled Krita with lcms2 v2.2...
Comment 3 Halla Rempt 2011-10-31 12:21:30 UTC
I don't exactly know how dispwin works; Krita only checks an X11 atom for the profile. If that isn't set, you can manually add and enable the profile in the color management settings dialog.
Comment 4 Ico_dY 2011-10-31 13:18:04 UTC
Yes, dispwin uses X11 atom for the profile.

In Krita's color management setting dialog it says:
Monitor Profile: Screen 1
Rendering Intent: Perceptual

So it's active, but doesn't work! ^^
Comment 5 Halla Rempt 2011-10-31 13:30:41 UTC
Hm. I installed it with the "icc profile installer" and the color management utility -- I think this is colord -- and I might have messed up my installation because now my how screen seems to be color-corrected...
Comment 6 Ico_dY 2011-10-31 13:56:01 UTC
I can't use gnome color manager since the version available in the repository/ppa it's not compatible with the proprietary nvidia driver.
I've tried to install the color profile with xcalib, but I've got the same result as dispwin...
Maybe I should try with a newer distro...
Now I'm using Mint 10 -> Ubuntu Maverick...
Comment 7 Ico_dY 2011-10-31 14:57:01 UTC
I've just tried with Debian testing, open-source nvidia driver and color profile installed with gnome color manager... Same wrong result-> No visual rendering! SOB
Maybe is it a Gnome 2 related bug/problem?
David Revoy have a monitor calibrated with a colorimeter as same as mine... The Krita's color management does it work for him? We could ask for a comparison...
Comment 8 Halla Rempt 2011-10-31 15:02:05 UTC
Oh! My last comment didn't get through because we had a collision in bugzilla. I've found the bug, it's a recent regression, I think, and I'll have a fix ready by tomorrow morning. Thanks for the report -- this was _very_ useful to us!
Comment 9 Ico_dY 2011-10-31 15:31:16 UTC
You're very welcome! ^^
Comment 10 Halla Rempt 2011-10-31 22:16:15 UTC
Git commit 9aa2199a9babe326b8d07e64c20382f556d6038a by Boudewijn Rempt.
Committed on 31/10/2011 at 23:14.
Pushed by rempt into branch 'master'.

Fix color management of the display

BUG:285382

We took the display profile from the kritarc config file, which when it's
set by colord or anything else wrong. So make sure that it's easy to get
the correct colorprofile and use that everywhere.

M  +2    -2    krita/benchmarks/kis_painter_benchmark.cpp
M  +1    -1    krita/image/kis_fixed_paint_device.h
M  +5    -4    krita/image/kis_paint_device.cc
M  +3    -3    krita/image/kis_paint_device.h
M  +2    -2    krita/image/kis_pattern.cc
M  +3    -3    krita/image/tests/kis_async_merger_test.cpp
M  +8    -8    krita/image/tests/kis_convolution_painter_test.cpp
M  +1    -1    krita/image/tests/kis_cs_conversion_test.cpp
M  +1    -1    krita/image/tests/kis_filter_job_test.cpp
M  +1    -1    krita/image/tests/kis_filter_mask_test.cpp
M  +8    -8    krita/image/tests/kis_filter_selections_benchmark.cpp
M  +3    -3    krita/image/tests/kis_filter_test.cpp
M  +6    -6    krita/image/tests/kis_fixed_paint_device_test.cpp
M  +10   -10   krita/image/tests/kis_paint_device_test.cpp
M  +1    -1    krita/image/tests/kis_processings_test.cpp
M  +14   -14   krita/image/tests/kis_transform_worker_test.cpp
M  +2    -2    krita/image/tests/kis_update_scheduler_test.cpp
M  +1    -1    krita/plugins/extensions/dockers/defaultdockers/kis_drop_button.cpp
M  +2    -2    krita/plugins/extensions/painterlyframework/mixercanvas.cpp
M  +4    -4    krita/plugins/filters/tests/kis_all_filter_test.cpp
M  +1    -1    krita/plugins/filters/tests/kis_crash_filter_test.cpp
M  +3    -3    krita/plugins/formats/bmp/kis_bmp_import.cpp
M  +2    -2    krita/plugins/formats/pdf/kis_pdf_import.cpp
M  +1    -1    krita/plugins/paintops/mypaint/tests/kis_mypaint_surface_test.cpp
M  +1    -1    krita/plugins/paintops/spray/spray_brush.cpp
M  +2    -2    krita/plugins/tools/defaulttools/tests/move_stroke_test.cpp
M  +8    -3    krita/ui/canvas/kis_canvas2.cpp
M  +6    -4    krita/ui/canvas/kis_image_pyramid.cpp
M  +3    -2    krita/ui/canvas/kis_prescaled_projection.cpp
M  +1    -1    krita/ui/flake/kis_shape_layer_canvas.cpp
M  +2    -3    krita/ui/kis_canvas_resource_provider.cpp
M  +1    -1    krita/ui/kis_canvas_resource_provider.h
M  +6    -7    krita/ui/kis_clipboard.cc
M  +10   -2    krita/ui/kis_config.cc
M  +3    -0    krita/ui/kis_config.h
M  +2    -3    krita/ui/kis_doc2.cc
M  +6    -8    krita/ui/kis_mimedata.cpp
M  +15   -16   krita/ui/kis_view2.cpp
M  +4    -4    krita/ui/tests/kis_prescaled_projection_test.cpp
M  +4    -2    krita/ui/widgets/kis_scratch_pad.cpp

http://commits.kde.org/calligra/9aa2199a9babe326b8d07e64c20382f556d6038a
Comment 11 Ico_dY 2011-10-31 23:36:03 UTC
It seems to work now! Well done! ^^