Bug 285240 - digikam fails to build with external libpgf-6.11.42
Summary: digikam fails to build with external libpgf-6.11.42
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Portability-Compilation (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-29 09:29 UTC by nucleo
Modified: 2017-08-19 21:06 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 2.3.0

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description nucleo 2011-10-29 09:29:07 UTC 
Version:           unspecified (using KDE 4.7.2) 
OS:                Linux

/builddir/build/BUILD/digikam-2.2.0/core/libs/dimg/loaders/pgfloader.cpp:423:75: error: 'struct PGFHeader' has no member named 'background'
make[2]: *** [core/digikam/CMakeFiles/digikamcore.dir/__/libs/dimg/loaders/pgfloader.cpp.o] Error 1

Reproducible: Didn't try


Actual Results:  



Expected Results:
Comment 1 caulier.gilles 2011-10-29 10:32:44 UTC 
Due to some bug in libpgf (library implementation still under development), it's highly recommend to use internal version which is a copy of current implementation from subversion repository.

Gilles Caulier
Comment 2 caulier.gilles 2011-10-29 10:33:10 UTC 
Also, which version of digiKam you use ?

Gilles Caulier
Comment 3 nucleo 2011-10-29 11:32:33 UTC 
digikam 2.2.0.
libpgf-6.11.42 is the same as current svn libpgf repository.
Comment 4 caulier.gilles 2011-10-29 11:43:21 UTC 
Are you sure, because libpgf from digiKam core compile fine. Can i see a complete compilation trace please, with all compilation options.

Gilles Caulier
Comment 5 nucleo 2011-10-29 11:51:22 UTC 
Build log
http://koji.fedoraproject.org/koji/getfile?taskID=3468951&name=build.log

New libpgf-6.11.42 sources released yesterday, this is current SVN snapshot
http://sourceforge.net/projects/libpgf/files/libpgf/6.11.42%20-%20latest/
Comment 6 caulier.gilles 2011-10-29 12:20:40 UTC 
Ah yes, libpgf have been release yesterday. I take a look.

Gilles Caulier
Comment 7 caulier.gilles 2011-10-29 19:06:01 UTC 
Git commit 51a92945ea0725fcca9c27435ee852003c441ad0 by Gilles Caulier.
Committed on 29/10/2011 at 21:04.
Pushed by cgilles into branch 'master'.

update internal libpgf to last stable 6.11.42. Fixbroken compilation due to API changes.
BUGS: 285240

M  +1    -1    libs/3rdparty/libpgf/BitStream.h
M  +20   -16   libs/3rdparty/libpgf/Decoder.cpp
M  +17   -17   libs/3rdparty/libpgf/Decoder.h
M  +14   -9    libs/3rdparty/libpgf/Encoder.cpp
M  +23   -23   libs/3rdparty/libpgf/Encoder.h
M  +156  -86   libs/3rdparty/libpgf/PGFimage.cpp
M  +46   -35   libs/3rdparty/libpgf/PGFimage.h
M  +37   -36   libs/3rdparty/libpgf/PGFplatform.h
M  +7    -7    libs/3rdparty/libpgf/PGFstream.h
M  +52   -50   libs/3rdparty/libpgf/PGFtypes.h
M  +9    -9    libs/3rdparty/libpgf/Subband.h
M  +8    -9    libs/3rdparty/libpgf/WaveletTransform.h
M  +5    -0    libs/dimg/loaders/pgfloader.cpp
M  +5    -0    libs/threadimageio/pgfutils.cpp

http://commits.kde.org/digikam/51a92945ea0725fcca9c27435ee852003c441ad0