Bug 285070 - Change Date and Time dialog should warn when no tag to change is selected
Summary: Change Date and Time dialog should warn when no tag to change is selected
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-TimeAdjust (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-27 09:28 UTC by Pascal Maillard
Modified: 2018-09-22 08:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.6.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Maillard 2011-10-27 09:28:35 UTC
Version:           1.9.0 (using KDE 4.6.5) 
OS:                Linux

When changing the Date and Time stamp of many pictures via the Date and Time stamp dialog and no tag to change is checked, digiKam runs through all the pictures anyway without changing anything. With many pictures, this will freeze digiKam for a possibly long time.

Reproducible: Always

Steps to Reproduce:
- Select many pictures.
- Open Image -> Change Date and Time dialog
- Select Exif/IPTC/XMP in the above combo box
- Uncheck any check boxes for the tags to change
- click OK

Actual Results:  
digiKam runs through all the pictures without actually changing something, freezing for a possibly long time

Expected Results:  
When clicking OK, digiKam should warn the user that no tag is selected and refuse to continue. Optionally, it could display a help message with description of the meaning of the various tags.

OS: Linux (x86_64) release 2.6.37.6-0.7-desktop
Compiler: gcc
Comment 1 caulier.gilles 2011-12-20 17:31:31 UTC
Pascal,

This file still valid using kipi-plugins 2.4 ?

Gilles Caulier
Comment 2 Pascal Maillard 2011-12-21 11:20:27 UTC
Sorry, I can't check, my distro (Opensuse 12.1) only provides 2.2.

Am Dienstag, 20. Dezember 2011, 17:31:31 schrieb Gilles Caulier:
> https://bugs.kde.org/show_bug.cgi?id=285070
> 
> 
> 
> 
> 
> --- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-12-20
> 17:31:31 --- Pascal,
> 
> This file still valid using kipi-plugins 2.4 ?
> 
> Gilles Caulier
Comment 3 Smit Mehta 2012-04-19 12:57:11 UTC
Hi Gilles

Yes its valid. Best possible solution is
- check for a condition inside slotOk() which checks for checkboxes, and if nothing is selected, then show a warning by KMessageBox

Smit
Comment 4 Smit Mehta 2012-04-19 13:47:36 UTC
Git commit 6127ec731f25eb383500bb63f81c08b4422e381b by smit mehta.
Committed on 19/04/2012 at 15:45.
Pushed by smitmehta into branch 'master'.

Error message if nothing is selected.

M  +35   -19   timeadjust/timeadjustdialog.cpp

http://commits.kde.org/kipi-plugins/6127ec731f25eb383500bb63f81c08b4422e381b