Currently we use the account name (normally email@example.com) which
1) is a bit hacky (especially with workarounds for local xmpp)
2) it displays raw addresses to a user, which look rubbish (i.e exposes @chat.facebook.com)
There is a FIXME in the code that says "prompt the user" for a display name. This is a rubbish solution. The less prompts the better.
The account plugins should have a method to return a sensible display string
so the facebook plugin can return "MyUserName (Facebook)" or some such. Local XMPP no longer needs a workaround in the main code.
This should be in AbstractAccountUi (or AbstractAccountUiPlugin.. not sure which) and not be virtual but not pure virtual. The default implementation acn return the account name so it works if the plugin is not updated.
I'm switching this to Accounts KCM as that's where it should be fixed.
I'm taking this...
Deferring till 0.5
(though can we get this merged!)
why did we not merge this?
Actually I had a patch on reviewboard and I wanted to make some changes to it, but I completely forgot... I will try to fix this asap, but it's probably too late for 0.5...
*** Bug 306094 has been marked as a duplicate of this bug. ***
Link to the review request https://git.reviewboard.kde.org/r/103628/
Stupid bugzilla doesn't like my brand new kde.org account so I'm closing it manually :P
Git commit 20f4d263e468f14c575dd44848db66bb6cd082e9 by Daniele E. Domenichelli.
Committed on 26/02/2013 at 14:04.
Pushed by ddomenichelli into branch 'master'.
Merge branch 'displayname'
Reviewed-by: David Edmundson <firstname.lastname@example.org>