Version: git-latest (using KDE 4.7.2) OS: Linux Nearly every KDE app (and others too) can be closed using Ctrl+Q. This is not possible for the Telepathy Contact list. Reproducible: Always Steps to Reproduce: 1. Open Telepathy Contact list 2. Try to close it using Ctrl+Q Actual Results: Contact list doesn't close. Expected Results: I'd expect the contact list to close when using Ctrl+Q - just the same as when using the window decoration's "close/quit" functionality.
In monolithic IM apps ctrl+q usually quits the program (which has the effect of taking the user offline) whereas alt+f4 and WM decoration close simply hides the contact list. Perhaps using Ctrl+Q in the contact list should set accounts to offline as well as closing the contact list as this would match the user expectations of anyone coming from a monolithic client (i.e. every other IM client). This is also closer to the behavior of IIRC most other applications which can minimise to the systray — at least akregator, amarok and kmail — all of which hide on alt+f4 or windeco close and quit completely on ctrl+q
Ok, I'll implement Ctrl+Q as an action that closes contact list and sets you offline - objections?
I don't see any reason to have special 'go offline' behaviour from window closing. Also if you inherit from the correct KXmlGuiWindow class, you should have control+w, control+q automagically.
Me neither but apparently other KDE apps do that - amarok - playing, alt+f4 closes but keeps playing, ctrl+q closes and stops playing, similar with kmail etc. I have no strong opinions on either one.
*** Bug 298937 has been marked as a duplicate of this bug. ***
Git commit b3958e127b84c1feb3a51c81825811b7bfa51176 by Roman Nazarenko. Committed on 02/03/2013 at 15:30. Pushed by romann into branch 'master'. Quit shortcut (Ctrl+Q) is fixed. REVIEW: 109241 M +6 -0 main-widget.cpp http://commits.kde.org/telepathy-contact-list/b3958e127b84c1feb3a51c81825811b7bfa51176