Bug 284752 - Skrooge does not look for Grantlee at build time
Summary: Skrooge does not look for Grantlee at build time
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources FreeBSD
: NOR normal
Target Milestone: ---
Assignee: Stephane MANKOWSKI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-22 23:54 UTC by Raphael Kubo da Costa
Modified: 2011-10-23 17:07 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa 2011-10-22 23:54:30 UTC 
Skrooge has no FindGrantlee.cmake responsible for checking if Grantlee actually exists before it is used in plugins/skrooge/skrooge_monthly/grantlee_filters/CMakeLists.txt.

It would be a good practice if Skrooge looked for Grantlee and warned when it is not installed.
Comment 1 Stephane MANKOWSKI 2011-10-23 10:50:53 UTC 
Hi,

As you can see there:
https://projects.kde.org/projects/extragear/office/skrooge/repository/revisions/master/entry/plugins/skrooge/skrooge_monthly/CMakeLists.txt

The FIND_PACKAGE for Grantlee is already present.
( Line 5: FIND_PACKAGE(Grantlee REQUIRED) )

What do you need more?
Comment 2 Raphael Kubo da Costa 2011-10-23 15:29:28 UTC 
If I try to build Skrooge 1.0.0 when Grantlee is not installed, I get the following messages:

  -- ..:: CMAKE PLUGIN_MONTHLY ::..
  CMake Error at plugins/skrooge/skrooge_monthly/CMakeLists.txt:5 (FIND_PACKAGE):
    Could not find module FindGrantlee.cmake or a configuration file for
    package Grantlee.

    Adjust CMAKE_MODULE_PATH to find FindGrantlee.cmake or set Grantlee_DIR to
    the directory containing a CMake configuration file for Grantlee.  The file
    will have one of the following names:

      GrantleeConfig.cmake
      grantlee-config.cmake

  --      GRANTLEE VERSION      : ..
  --      enable GRANTLEE 0.1.4 API
  -- ..:: CMAKE GRANTLEE_FILTERS ::..
  CMake Error at plugins/skrooge/skrooge_monthly/grantlee_filters/CMakeLists.txt:5 (INCLUDE):
    include called with wrong number of arguments.  Include only takes one
    file.

  CMake Error at plugins/skrooge/skrooge_monthly/grantlee_filters/CMakeLists.txt:11 (GRANTLEE_ADD_PLUGIN):
    Unknown CMake command "GRANTLEE_ADD_PLUGIN".

  -- Configuring incomplete, errors occurred!
Comment 3 Stephane MANKOWSKI 2011-10-23 17:02:51 UTC 
Git commit 948e58b007983c0cb6de963b614ff6cd6e652ced by Stephane Mankowski.
Committed on 23/10/2011 at 19:02.
Pushed by smankowski into branch 'Feature'.

BUG: 284752: Skrooge does not look for Grantlee at build time

M  +1    -0    CHANGELOG
M  +0    -3    CMakeLists.txt
M  +7    -1    plugins/skrooge/skrooge_monthly/CMakeLists.txt
M  +6    -1    skgbasemodeler/CMakeLists.txt
M  +1    -0    tests/CMakeLists.txt

http://commits.kde.org/skrooge/948e58b007983c0cb6de963b614ff6cd6e652ced
Comment 4 Raphael Kubo da Costa 2011-10-23 17:07:22 UTC 
Note that you can also use macro_optional_find_package+macro_log_feature instead of find_package+manually specifying error messages.