Version: unspecified (using KDE 4.7.1) OS: Linux ~/digikam-sc/core/libs/dmetadata/dmetadata.cpp: In static member function ‘static QString Digikam::DMetadata::valueToString(const QVariant&, Digikam::MetadataInfo::Field)’: ~/digikam-sc/core/libs/dmetadata/dmetadata.cpp:2410:1: error: control reaches end of non-void function [-Werror=return-type] cc1plus: some warnings being treated as error tcaswell@eowyn:~/other_source/digikam-sc$ g++ --version g++ (Ubuntu/Linaro 4.6.1-9ubuntu3) 4.6.1 It seems that the compiler does not agree that the default case will keep the program from getting out of the switch statement without returning. Adding the default return after the switch allows the code compile Reproducible: Always Steps to Reproduce: update to head of master branch Actual Results: - Expected Results: -
Stupid compiler, but I guess there is no choice to add the redundant "return QString();"
Which version do you compile ? Git/master ? Gilles Caulier
(In reply to comment #2) > Which version do you compile ? Git/master ? > > Gilles Caulier it's a gcc-4.6 warning, threathed like error, http://commits.kde.org/digikam/5bf4ba612516d2c15d4e6659f9653ae574735ace I've adopted the same solution as Christoph Feck #c1 in sql2.0 branch, should I cherry pick it to master?
yes, sure backport it and close this entry (:=)))
done