Bug 284417 - Phrase "Conversation Began" in default AdiumTheme (Renkoo) header is not translated
Summary: Phrase "Conversation Began" in default AdiumTheme (Renkoo) header is not tran...
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Frameworks and Libraries
Component: text-ui (show other bugs)
Version: unspecified
Platform: Unlisted Binaries Linux
: NOR minor
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2011-10-18 23:47 UTC by David Edmundson
Modified: 2013-05-20 12:48 UTC (History)
2 users (show)

See Also:
Latest Commit: http://commits.kde.org/telepathy-text-ui/37110472f3c840204231aac48310865f91117f53
Version Fixed In: 0.7.0

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description David Edmundson 2011-10-18 23:47:22 UTC 
Not much we can do about it, as it's in the HTML rather than any C++ code. There's no suitable fix we can use without just breaking theme support.
Comment 1 David Edmundson 2013-04-28 15:24:12 UTC 
I think we need to fix this soon, so lets do some horrible hack that only works with this one theme. I think we should treat Renkoo as a special case because we ship it by default, so should support it more than the other themes.

if we change the HTML to something like
==conversationBegan== instead of the raw text

and then do a find & replace in the cpp code with i18n("Conversation began %1").arg(theTime);
Comment 2 Daniele E. Domenichelli 2013-04-29 07:29:43 UTC 
Can anyone with a mac check if this is translated in adium?
Comment 3 Martin Klapetek 2013-04-29 09:00:45 UTC 
I have a mac but with english locale, so I'll check if I can change the locale and then check it.
Comment 4 Martin Klapetek 2013-05-02 17:42:29 UTC 
This phrase is not translated in original Adium in OS X.
Comment 5 David Edmundson 2013-05-20 12:48:32 UTC 
Git commit 37110472f3c840204231aac48310865f91117f53 by David Edmundson.
Committed on 20/05/2013 at 14:36.
Pushed by davidedmundson into branch 'master'.

Translate phrase "Conversation began" in Renkoo theme
FIXED-IN: 0.7.0
Reviewed-by: Dan Vratil

M  +1    -1    data/styles/renkoo.AdiumMessageStyle/Contents/Resources/Header.html
M  +4    -0    lib/adium-theme-view.cpp

http://commits.kde.org/telepathy-text-ui/37110472f3c840204231aac48310865f91117f53