Bug 284101 - Collection browser should show artist name for tracks with artist != album artist
Summary: Collection browser should show artist name for tracks with artist != album ar...
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Collection Browser (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: 2.5
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-15 14:32 UTC by Sebastian Frei
Modified: 2024-05-04 18:34 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Frei 2011-10-15 14:32:39 UTC
Version:           unspecified (using KDE 4.6.5) 
OS:                Linux

The collection browser prepends the track artist name to tracks shown under various artists/compilations. This behaviour is useful, because usually the tracks on compilations have different track artists. (Other people think exactly the opposite, see bug https://bugs.kde.org/show_bug.cgi?id=276039)

If there is an album where the tracks have different artists but all tracks have a unique album artist different to "Various Artists", the album is shown under the album artists name. This is also useful. But unfortunately the track artist is not prepended to the track title in the collection tree. I would like to have also here the track artist prepended to the track title.

A common usecase are tribute albums: They are tagged with the same album artist and different track artists. The album is shown under the album artist in the collection tree, but one cannot see the artists of the single tracks.

In the bug https://bugs.kde.org/show_bug.cgi?id=252790 a patch was introduced for the current behavior to prepend the track artist to the track title under Various artists. I think something like this could do the job:

src/browsers/CollectionTreeItemModelBase.cpp, line 195:
QVariant
CollectionTreeItemModelBase::dataForItem(...)
{
.
.
-  if( album && artist && album->isCompilation() )
+  if( album && artist && ( album->isCompilation() || (album->albumArtist() != track->artist)
                    name.prepend( QString("%1 - ").arg(artist->prettyName()) );
. 
.
.

Reproducible: Always

Steps to Reproduce:
Create some tracks with the same album title, the same album artist (but not Various Artists) and different track titles.

Actual Results:  
The album is shown under the album artist in the collection tree. The second layer shows the album title. The third layer shows only the track title.

Expected Results:  
In the third layer the track artist should be prepended to the track title.
Comment 1 Tuomas Nurmi 2024-05-04 18:34:26 UTC
Git commit 5b43ce29c392311f06727f45d60b0d196a88c85b by Tuomas Nurmi.
Committed on 04/05/2024 at 18:24.
Pushed by nurmi into branch 'master'.

Add configuration option for showing artist in various artist cases

As demonstrated by the bug reports, this is something where one solution does not
fit all. So add a configuration option; probably - and hopefully - the users who want
to see artist in various artists compilations also want to see them when artist
differs from album artist, and vice versa. Options should be added with care, but
I think this one is definitely justified.
Related: bug 276039

M  +5    -0    src/amarokconfig.kcfg
M  +6    -0    src/browsers/CollectionTreeItem.cpp
M  +1    -0    src/browsers/CollectionTreeItem.h
M  +3    -1    src/browsers/CollectionTreeItemModelBase.cpp
M  +12   -0    src/browsers/collectionbrowser/CollectionWidget.cpp
M  +1    -0    src/browsers/collectionbrowser/CollectionWidget.h

https://invent.kde.org/multimedia/amarok/-/commit/5b43ce29c392311f06727f45d60b0d196a88c85b