Bug 28319 - X-Face support
Summary: X-Face support
Status: RESOLVED FIXED
Alias: None
Product: kmail
Classification: Applications
Component: messageviewer (show other bugs)
Version: unspecified
Platform: Debian testing Other
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
: 37596 38400 86687 (view as bug list)
Depends on:
Blocks:
 
Reported: 2001-07-07 00:18 UTC by Andrew Somerville
Modified: 2013-09-03 14:48 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
schermafdruk12.png (31.35 KB, image/png)
2004-08-08 23:31 UTC, Tom Albers
Details
schermafdruk13.png (22.44 KB, image/png)
2004-08-08 23:31 UTC, Tom Albers
Details
schermafdruk17.png (9.43 KB, image/png)
2004-08-12 00:51 UTC, Tom Albers
Details
tr.tar.gz (1.62 KB, application/x-tgz)
2004-08-17 20:38 UTC, Tom Albers
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jblaylock 2001-07-07 00:09:43 UTC
(*** This bug was imported into bugs.kde.org ***)

Package:           kmail
Version:           KDE 2.1.1 
Severity:          wishlist
Installed from:    Debian Packages
Compiler:          Not Specified
OS:                Not Specified
OS/Compiler notes: Not Specified

faces support in kmail would be really neat.  Since it's a gui mail application you could display the faces right there.  Maybe if the sender sent one of those v-card thingies you could (optionally) display that in place of the face or where the face would be if they don't have one.  And you could assign faces to people in your address book; organize your contacts visually.  Maybe optionally display faces in lieu of FROM information.  

Faces would rule.

(Submitted via bugs.kde.org)
Comment 1 Warwick Allison 2002-11-15 08:59:45 UTC
Faces could be redithered randomly each time they are sent, so that over time the people you know best appear with greater resolution. 
Comment 2 Emiel Kollof 2003-02-26 21:44:11 UTC
This would be pretty cool to have. I agree. 
Comment 3 Wilbert Berendsen 2004-01-15 10:15:43 UTC
Yes I would really like this. Also Warwick's idea. I have sometimes difficulty to remember people I only meet by email, and when they have faces things look totally different.

It could even be implemented without much extra fuss for the user:
- use the photo from the addressbook entry that points to the user him/herself
- automagically add xfaces from other people that are already in your addressbook to your addresbook.

So an option in the KMail config for each identity could be:
[X] Send X-Face with your mail
(with a tooltip: To use X-Face, please add a photo to your own entry in the addressbook)

and another somewhere else
[X] Automatically add X-Faces of known contacts to their entry in your addressbook

The option to redither could be difficult to implement, because the algorithm should be able to catch the situation where a user changes his/her X-Face, and not try to create an image based on two X-Faces stemming from different images.

There are nice algorithms already to scale and refine small images, such as those mentioned on http://www.kdedevelopers.org/node/view/297

An alternative would be to use another way to fetch user-images, via an url or a vcard attachment, or even combined with the image setting for kdm???
Comment 4 Andrew Somerville 2004-04-14 04:24:36 UTC
What a great idea! 
Comment 5 Stephan Kulow 2004-05-18 21:21:38 UTC
Replaced jblaylock@lnxi.com with landrews@nbnet.nb.ca due to bounces by reporter
Comment 6 sehh 2004-06-08 04:29:50 UTC
Any luck with X-Face supprt in KMail? Bug 28319 and 37596 seem to be related (duplicate?).
Comment 7 Carsten Burghardt 2004-06-08 10:10:43 UTC
*** Bug 37596 has been marked as a duplicate of this bug. ***
Comment 8 Matt Dawson 2004-06-08 15:53:47 UTC
Could this functionality be extended to knode?
Comment 9 Jakob Schroeter 2004-07-20 15:53:10 UTC
I created a patch to add basic X-Face: header support to KMail.
One can set one X-Face per identity. When using fancy headers, the X-Face of a mail is displayed.
Testers welcome!
Get it at http://camaya.net (I will attach it here when I get around to make it one patch)

I will try and port the compface lib to a class or s.th.
Comment 10 Carsten Burghardt 2004-08-06 09:53:09 UTC
*** Bug 86687 has been marked as a duplicate of this bug. ***
Comment 11 Jakob Schroeter 2004-08-08 22:13:12 UTC
I polished the patch a bit, the X-Face stuff is in one class now.
No new functionality.
Get it at http://camaya.net
Comment 12 Tom Albers 2004-08-08 23:31:49 UTC
Just applied the patch and tested it:
- no compilation problems
- after installing, you go to your identity and there appears a tab x-face
- you put in an x-face-string (see http://www.xs4all.nl/~ace/X-Faces/)
- you can see the result directly (see screenie as well)
- all messages you send out contain this headerfield.
- when receiving, the x-face header will be parsed and becomes visible (see 
other screenie).

Remarks:
- Positition in message is slightly to much to the bottom, causing the 
headerblock to be a bit larger, should be easty to fix.
- I would like to have a set of x-faces available or at least a link to the 
page mentioned above. 

Looks like a nice new feature.

Tom Albers


Created an attachment (id=7042)
schermafdruk12.png

Created an attachment (id=7043)
schermafdruk13.png
Comment 13 Jakob Schroeter 2004-08-09 03:09:33 UTC
v3.1 addresses both problems Tom noticed.
Still at http://camaya.net
Comment 14 Tom Albers 2004-08-12 00:51:34 UTC
I get some random distortions in the x-face, especially on send and archive 
messages. Included a screenshot.
The header in the source is:

X-Face: &g,TR^}]UCSFpSX^vN.tR,Pj}|
+s$hHh(;j/-YRb@=?utf-8?q?=5Fb=5E=23Y=24d3=5F=3BC=7Bw=5Dm=24b-XO=0A_______?= 
2>dGqZp{8;:giI-QT+Xc]/DL4n&ibdaINBaIRtUOo2^paDTT/7ybIQ8CPqH$@Y+1u,=?utf-8?q?V=3D=0A_______?= 
AX~zZ9aMg<&r:I3&*v%^,NV416Ue8kCRt>?S>`NWtq,=?utf-8?q?D=25=24mzghS=7Bjo=2E6w=5BiFhrgR=7C6=264=0A_______?=
 =?utf-8?q?_0UlnVv+=5C!/Z=23=5D=7D+47DJ?=)u|3iz'+g,7tnF?W+"r%s{ith5{',"xd|{JO=

ideas?


Created an attachment (id=7084)
schermafdruk17.png
Comment 15 Wilbert Berendsen 2004-08-12 07:44:14 UTC
I think the header is garbled, it shows `=?utf-8?' on many places.
Comment 16 Jakob Schroeter 2004-08-15 01:37:12 UTC
AFAICT, this "utf-8" stuff is ok. It's just how mail is stored internally. The uncompface functions don't see it.

Tom, does the distortion happen with every message? Could you send me the header from the source again by private mail as b.k.o modifies the text (e.g. at)? Btw: did your spam filter eat my mail?
Comment 17 Tom Albers 2004-08-17 20:38:18 UTC
Here is a message. When i put it in a folder and load it (so, no 
imap-problem), the first time it is distorted. Constantly. When i doubleclick 
it (like in open twice,  fast after each other, before the first is open), 
the first is distorted, the second is perfect.
When copy and paste the header in the c-face fieldit is ok. No distortion.
I hope you can reproduce.


Created an attachment (id=7153)
tr.tar.gz
Comment 18 Jakob Schroeter 2004-08-17 23:20:10 UTC
Sorry, I cannot reproduce it. It looks good, regardless what I do.

Does the distorted image change, or is it always the same (for the same xface header)?
Comment 19 Tom Albers 2004-08-17 23:25:08 UTC
It changes. But it could as well be my installation. Maybe someone else should test as well.
Comment 20 Tom Albers 2004-08-22 23:41:27 UTC
After installing the off-by-one patch, the distortions are gone, imho this is ready to roll...
Comment 21 Jakob Schroeter 2004-08-23 01:15:39 UTC
One question regarding the license:

The original compface sources my patch is based on are released as follows:
"Permission is given to distribute these sources, as long as the
copyright messages are not removed, and no monies are exchanged."

And seem to be re-released as GPL according to this bugzilla entry for mozilla:
http://bugzilla.mozilla.org/show_bug.cgi?id=20417#c32
"Let me know if you need anything more from me than just this email to confirm a change to the GPL licence for the code."

Is this sufficient to include the source in kmail?
Comment 22 Tom Albers 2004-10-15 17:11:58 UTC
*** Bug 38400 has been marked as a duplicate of this bug. ***
Comment 23 Jakob Schröter 2004-11-23 13:46:30 UTC
CVS commit by schrot: 

- X-Face support for KMail. A X-Face can be set per identity, either from an existing image, the user's address book entry's picture or an image file. X-Faces of incoming messages will be displayed in the reader win with the fancy header style.
FEATURE: 28319


  M +1 -1      Makefile.am   1.306
  M +49 -30    headerstyle.cpp   1.25
  M +9 -0      identitydialog.cpp   1.47
  M +3 -0      identitydialog.h   1.9
  M +28 -0     kmcomposewin.cpp   1.891



Comment 24 mi+kde 2005-04-07 18:27:03 UTC
From reading this discussion, I get the impression, that:

	a) the compface sources were incorporated into KDE instead of using
	   libcompface;
	b) the X-Face: headers generated by KMail were never tested and may be
	   incompatible with other software supporting the feature (comment #16
	   in particular).

I'm yet to build KDE-3.4.0 to check these for myself. Can someone, please, disspell my fears? Thanks a lot -- I wanted this feature since, at least, 2002 (bug 45982).
Comment 25 Jakob Schröter 2005-04-12 01:33:29 UTC
kmail/knode do not depend on an external libcompface.
of course were x-face headers tested. i'm not aware of any incompatibilities.
Comment 26 Will Hill 2013-09-03 04:42:19 UTC
This feature was wonderful but now seems broken in KDE 4.  Fancy Headers no longer shows a face for any of my contacts using versions in Debian Squeeze and Debian Wheezy.
Comment 27 Laurent Montel 2013-09-03 05:27:05 UTC
Just it uses nepomuk to show it.
Work fine when nepomuk index your contact.
Regards
Comment 28 jos poortvliet 2013-09-03 14:48:31 UTC
Works great indeed: http://susepaste.org/58009002