Bug 282418 - Apper always offers unstable distribution upgrades
Summary: Apper always offers unstable distribution upgrades
Status: RESOLVED FIXED
Alias: None
Product: apper
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Daniel Nicoletti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-20 16:33 UTC by Kevin Kofler
Modified: 2012-04-02 23:52 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Kofler 2011-09-20 16:33:32 UTC
Version:           unspecified (using KDE 4.6.5) 
OS:                Linux

Apper (and KPackageKit before it, which is what I'm still running, but I checked the code in Apper master and the problem is still there) always offers unstable distribution upgrades, with no way to disable it.

Reproducible: Always

Steps to Reproduce:
Run Apper or KPackageKit on Fedora 15 with a backend which actually checks for distribution upgrades properly (i.e. PackageKit-zif, try this repository: http://repos.fedorapeople.org/repos/kkofler/zif-backport/fedora-zif-backport.repo to get a current version of zif for F15). (I have no idea why PackageKit-yum isn't able to list the distribution upgrades, I should probably file a bug about that too, but if that gets fixed, this bug will affect our users by default. :-( )

Actual Results:  
I keep getting pestered with prompts to upgrade to Fedora 16 prereleases. (By the way, the UI for those prompts is also suboptimal in KPK 0.6.3.3, it spams me with notifications all the time and puts up a rectangle above the list of updates each time I update, is Apper less annoying there? Or should I file another bug about that issue?)

Expected Results:  
Only stable releases are offered by default. Upgrading to unstable releases should only be offered if the user explicitly asked for it.

The issue is this code in Sentinel/DistroUpgrade.cpp:

void DistroUpgrade::distroUpgrade(PackageKit::Transaction::DistroUpgrade type, const QString &name, const QString &description)
{
    Q_UNUSED(type)


The "type" is what tells whether the upgrade is stable or unstable. Upgrades of type DistroUpgradeUnstable should not be shown by default.
Comment 1 Kevin Kofler 2011-09-20 21:29:27 UTC
(Quick workaround for zif users wanting to get left in peace: setting upgrade_releases_uri=file:///dev/null in /etc/zif/zif.conf .)
Comment 2 Daniel Nicoletti 2012-02-17 02:05:34 UTC
I think this issue is closed, as Apper now only show Stable Upgrades tho I still have to add a config so that users can choose.