Bug 281821 - [PATCH] kwin fails to build: several MAP_GET macros and redefinition of "struct QMetaTypeId<SWrapper::ClientGroup*>
Summary: [PATCH] kwin fails to build: several MAP_GET macros and redefinition of "stru...
Status: RESOLVED NOT A BUG
Alias: None
Product: kwin
Classification: Plasma
Component: scripting (other bugs)
Version First Reported In: 4.6.5
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-11 19:27 UTC by esigra
Modified: 2011-12-26 10:24 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
patch t (5.86 KB, patch)
2011-09-11 19:27 UTC, esigra
Details

Note You need to log in before you can comment on or make changes to this bug.
Description esigra 2011-09-11 19:27:56 UTC
Created attachment 63568 [details]
patch t

Version:           4.6.5 (using KDE 4.6.5) 
OS:                Linux

Build of kwin 4.6.5 fails in final mode because there are several
MAP_GET macros and "struct QMetaTypeId<SWrapper::ClientGroup*>".


Reproducible: Always

Steps to Reproduce:
1. tar jxvf kdebase-workspace-4.6.5.tar.bz2
2. cd kdebase-workspace-4.6.5
3. mkdir build
4. cd build
5. cmake -DKDE4_ENABLE_FINAL=ON ..
6. make kwin

Actual Results:  
In file included from /home/work/programmering/kdebase-workspace-4.6.5/build/kwin/kdeinit_kwin_final_cpp.cpp:55:
/home/work/programmering/kdebase-workspace-4.6.5/kwin/scripting/toplevel.cpp: At global scope:
/home/work/programmering/kdebase-workspace-4.6.5/kwin/scripting/toplevel.cpp:43: fel: "x" är inte namnet på en typ
/home/work/programmering/kdebase-workspace-4.6.5/kwin/scripting/toplevel.cpp:44: fel: "y" är inte namnet på en typ
/home/work/programmering/kdebase-workspace-4.6.5/kwin/scripting/toplevel.cpp:45: fel: "size" är inte namnet på en typ
/home/work/programmering/kdebase-workspace-4.6.5/kwin/scripting/toplevel.cpp:46: fel: "width" är inte namnet på en typ
/home/work/programmering/kdebase-workspace-4.6.5/kwin/scripting/toplevel.cpp:47: fel: "height" är inte namnet på en typ
/home/work/programmering/kdebase-workspace-4.6.5/kwin/scripting/toplevel.cpp:48: fel: "geometry" är inte namnet på en typ
/home/work/programmering/kdebase-workspace-4.6.5/kwin/scripting/toplevel.cpp:49: fel: "opacity" är inte namnet på en typ
/home/work/programmering/kdebase-workspace-4.6.5/kwin/scripting/toplevel.cpp:50: fel: "hasAlpha" är inte namnet på en typ

Expected Results:  
[100%] Built target kwin
Comment 1 Martin Flöser 2011-09-12 07:42:13 UTC
 For patches please use reviewboard.kde.org - it is better to handle the 
 review.

 As you might know scripting is unmaintained and close to being removed 
 again. A patch which introduces lots of ifdefs will certainly not be 
 accepted. If we want really need support for build with final (given 
 that 4.6 had been released in January and nobody complained, it seems to 
 not be needed) I would suggest to just disable final build for scripting 
 as we already do for other parts of KWin.
Comment 2 Martin Flöser 2011-09-25 08:29:33 UTC
Please move to reviewboard