Bug 281742 - ICONVIEW : wrong selection start when browsing images
Summary: ICONVIEW : wrong selection start when browsing images
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Thumbs-IconView (show other bugs)
Version: 5.0.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-10 11:18 UTC by Frederic Grelot
Modified: 2017-07-28 15:15 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.5.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Grelot 2011-09-10 11:18:33 UTC
Version:           2.1.0 (using KDE 4.7.1) 
OS:                Linux

when I use shift+click to select images after switching with "pgup/pgdown", the selection is wrong

Reproducible: Always

Steps to Reproduce:
Have an album with few images, let's name them A,B,C,D,E,F. Select (by clicking) image A. double-click to open preview (maybe not necessary).
Using only "pgdown" (twice), go to image C.
Now, you want to select images C - D - E : since C is selected, you need to press shift and click on image E

Actual Results:  
Images A - B - C - D - E get selected : the beginning of the selection is the last image that has been selected using the mouse (A) : pgup/down don't change it

Expected Results:  
Images C - D - E should be selected, since the start of the selection should be C, which has been selected using pgup/down.

OS: Linux (x86_64) release 3.0.1-3.fc16.x86_64
Compiler: gcc
Comment 1 Marcel Wiesweg 2011-09-11 14:27:07 UTC
I can confirm. There seem to be separate problems with the thumbbar icon view (initial image is taken as start) and after returning to main icon view (by unclear logic, a following image is taken as start)
Comment 2 Marcel Wiesweg 2011-09-18 11:28:38 UTC
I have been trying to investigate this problem. Apparently, the starting point of a shift+click selection is chosen by QAbstractItemView by setting a private, internal coordinate at relevant points.
We are syncing the two views (icon view, thumb bar), but whatever we do, we cannot access the internal variable. I may not have completely understood every part of the rather complex selection code in Qt, but at the moment I dont see anything we can do to fix this bug.
Comment 3 Marcel Wiesweg 2012-07-08 11:42:34 UTC
*** Bug 296653 has been marked as a duplicate of this bug. ***
Comment 4 caulier.gilles 2014-08-31 17:26:07 UTC
Frederic,

This file still valid using last digiKam 4.2.0 ?

Gilles Caulier
Comment 5 Frederic Grelot 2014-08-31 19:23:58 UTC
Yes (4.2.0 from standard fedora repos)
To reproduce : in an album, Say you have 3 pictures, A, B, C.
Click 'A' to go in "Image view mode" ('A' in big, and a line of thumbnails at the top). Then, hit pgdown : you now see image B, and it gets selected in the top navigation bar. Press Shift+click on C.
Expected result : B+C should get selected
Actual result : A+B+C get selected.
Comment 6 caulier.gilles 2014-09-12 20:25:19 UTC
Frederic, 

This file is a duplicate of bug #311652, or vice versa ?

Note : Thumbbar or Icon-View use the same common implementation to model thumbnails.

Gilles Caulier
Comment 7 caulier.gilles 2015-05-16 13:33:30 UTC
Frederic,

Did you seen my previous comment ?

Gilles Caulier
Comment 8 caulier.gilles 2016-07-06 14:00:41 UTC
This problem still valid using last digiKam 5.0.0 ?

Gilles Caulier
Comment 9 DrSlony 2016-07-08 19:43:17 UTC
Still valid in 5.0.0 (92997d9c6c589e044ab77c3ca1e726627ae2e0a3).

KDE Frameworks 5.23.0
Qt 5.6.1 (built against 5.6.1)
Comment 10 caulier.gilles 2016-11-25 14:45:46 UTC
What's about this file using digiKam AppImage bundle 5.4.0 pre release given at
this url :

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

Gilles Caulier
Comment 11 Maik Qualmann 2017-01-23 11:41:38 UTC
Maik Qualmann 2017-01-15 09:39:13 UTC
Git commit 98bdea2b65ddef17eb2e973f748359b3ced3555b by Maik Qualmann.
Committed on 15/01/2017 at 09:35.
Pushed by mqualmann into branch 'master'.

fix syncing thumbbar selection
FIXED-IN: 5.5.0

M  +2    -1    NEWS
M  +7    -2    app/views/stackedview.cpp
M  +9    -11   utilities/importui/views/importstackedview.cpp

https://commits.kde.org/digikam/98bdea2b65ddef17eb2e973f748359b3ced3555b
Comment 12 Maik Qualmann 2017-02-13 07:05:52 UTC
*** Bug 376427 has been marked as a duplicate of this bug. ***
Comment 13 Bill Goodman 2017-02-13 23:47:13 UTC
(In reply to Maik Qualmann from comment #12)
> *** Bug 376427 has been marked as a duplicate of this bug. ***

Great! I can confirm that this fix seems to have fixed the problem observed on Windows 7.