Bug 281675 - remove tabs in "Torrent" page
Summary: remove tabs in "Torrent" page
Status: RESOLVED FIXED
Alias: None
Product: ktorrent
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Joris Guisson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-09 10:05 UTC by rockonthemoonfm
Modified: 2012-11-07 10:52 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description rockonthemoonfm 2011-09-09 10:05:18 UTC
Version:           unspecified (using KDE 4.7.0) 
OS:                Linux

the list of torrents is displayed in a tabbed field.
actually there is no practical reason to use tabs in this place.
please, remove tabs and leave a much cleaner interface with minimal chrome.

Reproducible: Didn't try



Expected Results:  
no tabs in Torrent view, clean interface.
Comment 1 Joris Guisson 2011-09-18 08:20:38 UTC
Git commit 814826dee4ae7029549c17ba47c8ea433fe39308 by Joris Guisson.
Committed on 18/09/2011 at 10:19.
Pushed by guisson into branch 'master'.

Remove multiple views support

BUG: 281675

M  +1    -0    ChangeLog
M  +1    -1    ktorrent/CMakeLists.txt
M  +1    -19   ktorrent/groups/groupview.cpp
M  +3    -6    ktorrent/groups/groupview.h
M  +0    -1    ktorrent/gui.cpp
M  +1    -3    ktorrent/kttorrentactivityui.rc
M  +19   -107  ktorrent/torrentactivity.cpp
M  +2    -33   ktorrent/torrentactivity.h
M  +413  -62   ktorrent/view/view.cpp
M  +64   -16   ktorrent/view/view.h
A  +72   -0    ktorrent/view/viewjobtracker.cpp     [License: GPL (v2+)]
A  +51   -0    ktorrent/view/viewjobtracker.h     [License: GPL (v2+)]
D  +0    -800  ktorrent/view/viewmanager.cpp
D  +0    -218  ktorrent/view/viewmanager.h
M  +3    -2    libktcore/interfaces/torrentactivityinterface.h
M  +22   -23   libktcore/torrent/jobtracker.cpp
M  +1    -2    libktcore/torrent/jobtracker.h

http://commits.kde.org/ktorrent/814826dee4ae7029549c17ba47c8ea433fe39308
Comment 2 rockonthemoonfm 2011-09-18 09:19:15 UTC
nice! 
have a nice day
alex
Comment 3 Alexey Shildyakov 2011-09-19 08:01:13 UTC
I couldn't agree with you. The reasons to use tabs are:
- Different tabs for uploads, downloads
- Different tabs for different groups (by series, by director, by tracker, by company)

I think we should decide about actions in UI like this by gathering user statistics. It's a general idea in web applications to improve usablility. But I don't see any such mechanisms in KDE apps. The implementation is not easy  so now we only hope User tell us about this UI change.
Comment 4 Joris Guisson 2011-09-19 16:24:31 UTC
> I couldn't agree with you. The reasons to use tabs are:
> - Different tabs for uploads, downloads
> - Different tabs for different groups (by series, by director, by tracker, by
> company)

You can only watch one tab at the same time. Instead of switching using the tab bar you now have to use the groups tree.
Comment 5 nucleo 2012-01-07 15:07:45 UTC
I always used tabs because it is easier to switch tabs (when groups tree closed) than opening/closing groups tree and then selecting downloads/uploads there.
I suggest to implement tabs feature as in konqueror. No tabs shown there by default if only one tab opened. Also konqueror have option to show tabs even for one tab.
Comment 6 ml 2012-01-09 19:02:15 UTC
idiotic bugreport, without tabs it's unusable for me, switching to qbittorent.
Comment 7 nucleo 2012-01-09 19:06:54 UTC
(In reply to comment #6)
> idiotic bugreport, without tabs it's unusable for me, switching to qbittorent.

Bugreport itself is fine, but fix is wrong for me.
Right fix will be made tabs behavior Konqueror-like i.e. no tabs shown for one opened tab.
Comment 8 Alexey Shildyakov 2012-01-09 19:14:19 UTC
Hmmm... I think that Nucleo's idea is good. But I don't know is it possible to
simple make this changes.
Anyway, what is the real purpose to use multiple tabs? What do you have in
separate tabs?
Comment 9 nucleo 2012-01-09 19:16:52 UTC
(In reply to comment #8)

> Anyway, what is the real purpose to use multiple tabs? What do you have in separate tabs?
First tab is Downloads, Second tab is Uploads.
Switching between tabs is more simple than opening groups tree every time before switching there.
Comment 10 ml 2012-01-09 19:19:25 UTC
(In reply to comment #8)
> Hmmm... I think that Nucleo's idea is good. But I don't know is it possible to
> simple make this changes.
> Anyway, what is the real purpose to use multiple tabs? What do you have in
> separate tabs?

For example custom groups of torrents e.g films, music etc. each in its own tab and it was easy to view number of torrents in each group(tab) also switching with tabs less complicated.
Comment 11 rockonthemoonfm 2012-01-09 19:30:33 UTC
nucleo's solution would work for me. Tabs thing is just about vertical space and polish.
personally I don't care about uploads, ktorrent options manage them well.
No need to continuously switching between ups/downs.
I just need to filter them out.
I'm not either a great fan of groups tree.
Adding a "Filter" item in menu bar could do the job too.
Comment 12 Alexey Shildyakov 2012-01-09 19:59:15 UTC
Ok. Lets me summarize.
You want:
- After program starts you don't see any tab
- Add tab by File -> New tab or Ctrl+T
- When there are 2 tabs or more, the tabs will be displayed as usual.
- When only one tab have kept, the tab bar will be hidden

So, are the actions to add tab in only two ways: button from menu and shortcuts enough for all of us?
Comment 13 nucleo 2012-01-09 20:02:35 UTC
(In reply to comment #12)
> So, are the actions to add tab in only two ways: button from menu and shortcuts
> enough for all of us?
Should be fine.
But also will be nice to have configuration option for showing tabs always.
Comment 14 nucleo 2012-01-09 20:13:45 UTC
And of course restore buttons for new tab and close tab that will be shown or hidden with tabs.
Comment 15 Elián Hanisch 2012-11-07 10:24:04 UTC
I did like to see an option for enable/disable tabs as well, I used the tab bar a lot :/
Comment 16 Elián Hanisch 2012-11-07 10:26:50 UTC
can we reopen this or shall I fill a new bug?
Comment 17 nucleo 2012-11-07 10:52:06 UTC
Tabs reenabled in ktorrent-4.3.