Created attachment 63488 [details] Patch to make preview background black in fullscreen Version: 2.1.0 (using KDE 4.6.2) OS: Linux This patch changes the background color of the preview to black if it is in fullscreen mode. Also the border is changed to no border. This way it's easier to review the photo on a black background. Reproducible: Always Steps to Reproduce: Apply the patch ;) Actual Results: The background is white (depending on the theme). Expected Results: Black background for Preview in Fullscreen mode. I'm not sure if this is the best way to implement it or if it would be better to use signals & slots, but it works...
Thanks for the patch We will review it for 2.2.0 Gilles Caulier
Bruno, Can you update your patch for next 2.5.0 release. Thanks in advance Gilles Caulier
Created attachment 67945 [details] Patch for 2.5.0 The patch based on 2.5.0...
Bruno, Your patch cannot be applied against git/master. Please update it : [gilles@localhost core]$ patch -p1 < digikam-fullscreen-black-2.5.0.diff patching file digikam/main/digikamapp.cpp Hunk #1 succeeded at 2744 with fuzz 2 (offset 69 lines). patching file digikam/views/digikamview.cpp Hunk #1 succeeded at 1995 with fuzz 1 (offset 116 lines). patching file digikam/views/digikamview.h Hunk #1 FAILED at 76. 1 out of 1 hunk FAILED -- saving rejects to file digikam/views/digikamview.h.rej patching file libs/widgets/graphicsview/graphicsdimgview.cpp patching file libs/widgets/graphicsview/graphicsdimgview.h Hunk #1 succeeded at 71 (offset 3 lines). Gilles Caulier
On 10/30/2013 03:35 PM, Gilles Caulier wrote: > https://bugs.kde.org/show_bug.cgi?id=281574 > > --- Comment #4 from Gilles Caulier <caulier.gilles@gmail.com> --- > Bruno, > > Your patch cannot be applied against git/master. Please update it : > > [gilles@localhost core]$ patch -p1 < digikam-fullscreen-black-2.5.0.diff > patching file digikam/main/digikamapp.cpp > Hunk #1 succeeded at 2744 with fuzz 2 (offset 69 lines). > patching file digikam/views/digikamview.cpp > Hunk #1 succeeded at 1995 with fuzz 1 (offset 116 lines). > patching file digikam/views/digikamview.h > Hunk #1 FAILED at 76. > 1 out of 1 hunk FAILED -- saving rejects to file > digikam/views/digikamview.h.rej > patching file libs/widgets/graphicsview/graphicsdimgview.cpp > patching file libs/widgets/graphicsview/graphicsdimgview.h > Hunk #1 succeeded at 71 (offset 3 lines). > > Gilles Caulier > No wonder if you try to apply the patch two years after I originally sent it in... :( I don't have a development environment set up for this right now, so I can not rebase. The patch is simple enough that you could easily integrate the changes if you wanted. bruno
Hi Bruno, >I don't have a development environment set up for this right now, so I >can not rebase. The patch is simple enough that you could easily >integrate the changes if you wanted. yes, bu ti have other patches to review in my TODO list, and list is long. So for me the best way is to delegate as i can to optimize time. I cannot do all. Sorry... Gilles Caulier
On 10/30/2013 03:53 PM, Gilles Caulier wrote: > yes, bu ti have other patches to review in my TODO list, and list is long. So > for me the best way is to delegate as i can to optimize time. I cannot do all. > Sorry... OK, But did you even look at the patch? The part which failed is just one line in digikam/views/digikamview.h + void toggleFullScreen(bool); - Should be very easy to fix. Anyhow take it or leave it, as I said it's been two years... bruno
Only format the patch to be compatible with git/master, i will test it and look problem with toggleFullScreen() Thanks Gilles Caulier
Bruno, Can you update your patch against git/master implementation. I think your solution will improve Preview mode in full screen mode. Thanks in advance Gilles Caulier
Git commit 4cf170065957084e0a63bb335328a419b208574f by Gilles Caulier. Committed on 05/09/2014 at 21:49. Pushed by cgilles into branch 'master'. Apply patch #67945 to change canvas background to black in fullscreen mode in Preview Mode to improve image review. Adapt this patch to ImportUI and LightTable which use same preview widget. ImportUI : force to reload settings when setup have been changed FIXED-IN: 4.3.0 M +2 -1 NEWS M +2 -0 digikam/main/digikamapp.cpp M +5 -0 digikam/views/digikamview.cpp M +1 -0 digikam/views/digikamview.h M +15 -1 libs/widgets/graphicsview/graphicsdimgview.cpp M +2 -1 libs/widgets/graphicsview/graphicsdimgview.h M +20 -8 utilities/importui/main/importui.cpp M +2 -1 utilities/importui/main/importui.h M +5 -0 utilities/importui/views/importview.cpp M +1 -0 utilities/importui/views/importview.h M +6 -0 utilities/lighttable/lighttableview.cpp M +1 -0 utilities/lighttable/lighttableview.h M +1 -0 utilities/lighttable/lighttablewindow.cpp http://commits.kde.org/digikam/4cf170065957084e0a63bb335328a419b208574f